Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoking search on a help page shifts the whole content to the left #56

Closed
VitGottwald opened this issue Apr 3, 2024 · 6 comments
Closed

Comments

@VitGottwald
Copy link
Sponsor

Fist of all great job with the docs site and search!

I just tried it for the first time and tried searching and noticed a small glitch.

When I go to a doc page, for example https://neovim.io/doc/user/undo.html#undo-commands and I press CMD+K to invoke the search functionality, the whole content shifts to the right. After closing the search dialog, the content shifts back to the left

Untitled
Untitled2

For some reason this does not happen on the main page https://neovim.io/doc/ .

@justinmk
Copy link
Member

justinmk commented Apr 3, 2024

Patch welcome. Surely with all the web devs out there, someone could help with this?

@Bashamega
Copy link

Hello:)
I have tested it on my windows computer and it worked.

@justinmk
Copy link
Member

Yeah, I can't reproduce this. I assume it was fixed by one of the recent CSS changes.

@VitGottwald
Copy link
Sponsor Author

Just tried it and it on https://neovim.io/doc/user/undo.html#undo-commands and I can reproduce it.

@justinmk
Copy link
Member

Well I can't, so without a PR this is wontfix

@VitGottwald
Copy link
Sponsor Author

It is best visible with viewport width over 1200px. For smaller width the content of the second grid column with navigation shifts.

I am able to consistently reproduce it on Chrome, Safari, and Firefox.

It is apparently caused by .DocSearch--active class on body when the search is open. Removing the class or the rule overflow: hidden !important; it contains fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants