Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle fullscreen uses incorrect borderless function for MacOS #2532

Open
diocletiann opened this issue May 9, 2024 · 0 comments
Open

Toggle fullscreen uses incorrect borderless function for MacOS #2532

diocletiann opened this issue May 9, 2024 · 0 comments
Labels
bug Something isn't working macos Specific to macOS and not investigable on other platforms

Comments

@diocletiann
Copy link

Describe the bug

neovide/src/window/window_wrapper.rs

Line 179 in af98449

window.set_fullscreen(Some(Fullscreen::Borderless(handle)));
also creates a dedicated space on MacOS. For correct borderless in current space it should be:

window.set_simple_fullscreen(true);

To Reproduce
toggle fullscreen

Expected behavior
fullscreen borderless window in current space

Desktop (please complete the following information):

  • OS: macOS 14.3.1
  • Neovide Version: main
  • Neovim Version: master
@diocletiann diocletiann added the bug Something isn't working label May 9, 2024
@fredizzimo fredizzimo added the macos Specific to macOS and not investigable on other platforms label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working macos Specific to macOS and not investigable on other platforms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fredizzimo @diocletiann