Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neovide crashing while "working" Value not an Array: '{"kind": "syntax", "hi_name": "SignColumn"... } #2452

Closed
lucax88x opened this issue Mar 29, 2024 · 16 comments
Labels
bug Something isn't working neovim-upstream Requires/is blocked on a change in Neovim itself

Comments

@lucax88x
Copy link

Describe the bug
This morning neovide just keep crashing because of treesitter highlight change (check the logs below)

To Reproduce
Steps to reproduce the behavior:
Checking logs, might related to redraw of neovide?

Expected behavior
A clear and concise description of what you expected to happen.
To not crash

Desktop (please complete the following information):

  • OS: 14.4.1
  • Neovide Version 0.12.2
  • Neovim Version v0.10.0-dev-2739+ge2224a793

crash log

@lucax88x lucax88x added the bug Something isn't working label Mar 29, 2024
@fredizzimo
Copy link
Member

fredizzimo commented Mar 29, 2024

This is either some regression in Neovim nighly or some new event we don't handle. I will take a look at it soon, but do you remember when you last updated Neovim before today?

@lucax88x
Copy link
Author

no more than 2/3 days

@fredizzimo
Copy link
Member

Unfortunately. I can't reproduce this here, it's probably caused by some plugin, can you try to run neovide -- --clean and see if it happens?

@fredizzimo
Copy link
Member

fredizzimo commented Mar 29, 2024

Most likely the nvim-treesitter-context plugin, I will try to install that here. That's not it, at least not for me.

@fredizzimo
Copy link
Member

It looks like some of the data we get from Neovim might be lost on the way. The response we get for nvim_input is not supposed to be {"kind": "syntax", "hi_name": "SignColumn", "id": 449}, that's a HighlightAttributeDefine.

It might be caused by the same underlying issue as this:

@CertainLach
Copy link

Also experiencing with nvim_input_mouse when I try to enable https://github.com/lewis6991/hover.nvim

Caused by:
    0: Error decoding response to request 'nvim_input_mouse'
    1: Error while decoding
    2: Value not an Array: '{"kind": "syntax", "hi_name": "GruvboxRedUnderline", "id": 167}'

(I understand this is not a neovide issue per se)

@fredizzimo
Copy link
Member

@CertainLach, thanks, is that plugin enough to reproduce the issue? If you follow this:
https://github.com/neovim/neovim/blob/master/contrib/minimal.lua,

If you prefer you can alternatively create a single file lazy.nvim configuration that can be launched with NVIM_APPNAME=notarray neovide, the config then goes into .config/notarray instead of the normal.config.nvim

@fredizzimo
Copy link
Member

I tried to reproduce this again, but I didn't manage to with the latest version of https://github.com/lewis6991/hover.nvim and neovim nightly.

So, it would be good to get a full configuration that can reproduce the problem. It's likely some combination of plugins that is the cause.

@lucax88x
Copy link
Author

lucax88x commented Apr 5, 2024

Really hard to reproduce sadly, it happens randomly.

@vargad
Copy link

vargad commented Apr 5, 2024

I'm having the same issue with neovide 0.12.2, and the latest neovim v0.10.0-dev-2806+g9af355964-dirty. I'm not using treesitter nor hover, not sure which plugin triggers it.

ERROR [neovide::bridge::ui_commands] Mouse Scroll Failed

Caused by:
    0: Error decoding response to request 'nvim_input_mouse'
    1: Error while decoding
    2: Value not an Array: '{"kind": "syntax", "hi_name": "SpellCap", "id": 173}'
ERROR [neovide::bridge] Error: 'Error reading message'

@fredizzimo
Copy link
Member

Maybe it's not a plugin. I have quite strong hunch that this might be doing something wrong

It seem to do so in the terminal mode:

Would it be possible for someone to test it either by reverting neovim/neovim@55c9e2c, or a with a version prior to it?

I don't think there are any readymade binaries available for that anymore, so you probably have to build Neovim yourself.

@vargad
Copy link

vargad commented Apr 5, 2024

A conflict was not trivial to resolve so I made a build with neovim/neovim@6525832 . Will see if it stops crashing. I believe this version will likely make neovide freeze.

@vargad
Copy link

vargad commented Apr 9, 2024

Sorry, I was a bit busy in the past days, but so far no crash, no hang. This neovim/neovim@6525832 neovim revision seems good with the latest neovide release.

@fredizzimo
Copy link
Member

Thanks, I reported our findings here:
neovim/neovim#27859 (comment)

@fredizzimo
Copy link
Member

Can you all test with the latest Neovim nightly build from today? There's another potential fix here

@fredizzimo fredizzimo added the neovim-upstream Requires/is blocked on a change in Neovim itself label May 17, 2024
@fredizzimo
Copy link
Member

The fix is most likely fixed in Neovim 0.10.0 and since our new 0.13.0 release requires that, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neovim-upstream Requires/is blocked on a change in Neovim itself
Projects
None yet
Development

No branches or pull requests

4 participants