Skip to content

Commit 86a2fc9

Browse files
committed
grid.View: getCellId() => using getRowId() #6662
1 parent a7ebeef commit 86a2fc9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/grid/View.mjs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ class GridView extends Component {
498498
}
499499

500500
if (!cellId) {
501-
cellId = me.getCellId(record, column.dataField)
501+
cellId = me.getCellId(rowIndex, column.dataField)
502502
}
503503

504504
if (selectedCells.includes(cellId)) {
@@ -711,12 +711,12 @@ class GridView extends Component {
711711
}
712712

713713
/**
714-
* @param {Object} record
714+
* @param {Number} rowIndex
715715
* @param {String} dataField
716716
* @returns {String}
717717
*/
718-
getCellId(record, dataField) {
719-
return this.id + '__' + record[this.store.getKeyProperty()] + '__' + dataField
718+
getCellId(rowIndex, dataField) {
719+
return this.getRowId(rowIndex) + '__' + dataField
720720
}
721721

722722
/**
@@ -854,7 +854,7 @@ class GridView extends Component {
854854
getRowId(rowIndex) {
855855
let me = this;
856856

857-
return `${me.id}__row__${rowIndex}`
857+
return `${me.id}__row-${rowIndex % (me.availableRows + 2 * me.bufferRowRange)}`
858858
}
859859

860860
/**
@@ -1044,10 +1044,10 @@ class GridView extends Component {
10441044
*/
10451045
updateCellNode(record, dataField) {
10461046
let me = this,
1047-
cellId = me.getCellId(record, dataField),
1047+
rowIndex = me.store.indexOf(record),
1048+
cellId = me.getCellId(rowIndex, dataField),
10481049
cellNode = VDomUtil.find(me.vdom, cellId),
10491050
needsUpdate = false,
1050-
rowIndex = me.store.indexOf(record),
10511051
cellStyle, cellVdom, column, columnIndex;
10521052

10531053
// The vdom might not exist yet => nothing to do in this case

0 commit comments

Comments
 (0)