Merge pull request #1097 from neomjs/dev

tobiu · web-flow · commit 39beac3d087c · 2020-08-18T00:00:57.000+02:00
1.3.53
diff --git a/apps/website/data/examples_devmode.json b/apps/website/data/examples_devmode.json
@@ -2,7 +2,7 @@
     {
         "browsers"    : ["Chrome v83+ (SharedWorkers)"],
         "environments": ["Desktop"],
-        "id"          : 16,
+        "id"          : 17,
         "image"       : "devmode/sharedcovid.png",
         "name"        : "Multi Window Covid App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/sharedcovid",
@@ -11,7 +11,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 15,
+        "id"          : 16,
         "image"       : "devmode/calendar-preview.png",
         "name"        : "Calendar Sneak Preview",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/src/calendar",
@@ -20,7 +20,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 14,
+        "id"          : 15,
         "image"       : "devmode/covidDashboard.png",
         "name"        : "Covid Dashboard",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/covid",
@@ -29,7 +29,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 13,
+        "id"          : 14,
         "image"       : "devmode/realworldApp.png",
         "name"        : "RealWorld App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/realworld",
@@ -38,7 +38,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 12,
+        "id"          : 13,
         "image"       : "devmode/coronaGallery.png",
         "name"        : "COVID-19 Gallery",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaGallery",
@@ -47,7 +47,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 11,
+        "id"          : 12,
         "image"       : "devmode/coronaHelix.png",
         "name"        : "COVID-19 Helix",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaHelix",
@@ -56,7 +56,7 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 10,
+        "id"          : 11,
         "image"       : "devmode/website.png",
         "name"        : "Neo Website App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/website",
@@ -65,12 +65,21 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 9,
+        "id"          : 10,
         "image"       : "devmode/tableFiltering.png",
         "name"        : "Table Filtering",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/tableFiltering",
         "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/examples/tableFiltering/"
     },
+    {
+        "browsers"    : ["Chrome"],
+        "environments": ["Desktop"],
+        "id"          : 9,
+        "image"       : "devmode/dragdrop.png",
+        "name"        : "Dialog drag&drop",
+        "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/dialog",
+        "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/examples/dialog/"
+    },
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
diff --git a/apps/website/data/examples_dist_dev.json b/apps/website/data/examples_dist_dev.json
@@ -2,7 +2,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 14,
+        "id"          : 15,
         "image"       : "devmode/calendar-preview.png",
         "name"        : "Calendar Sneak Preview",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/src/calendar",
@@ -11,7 +11,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 13,
+        "id"          : 14,
         "image"       : "devmode/covidDashboard.png",
         "name"        : "Covid Dashboard",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/covid",
@@ -20,7 +20,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 12,
+        "id"          : 13,
         "image"       : "devmode/realworldApp.png",
         "name"        : "RealWorld App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/realworld",
@@ -29,7 +29,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 11,
+        "id"          : 12,
         "image"       : "devmode/coronaGallery.png",
         "name"        : "COVID-19 Gallery",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaGallery",
@@ -38,7 +38,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 10,
+        "id"          : 11,
         "image"       : "devmode/coronaHelix.png",
         "name"        : "COVID-19 Helix",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaHelix",
@@ -47,7 +47,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop", "Mobile"],
-        "id"          : 9,
+        "id"          : 10,
         "image"       : "devmode/website.png",
         "name"        : "Neo Website App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/website",
@@ -56,12 +56,21 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 8,
+        "id"          : 9,
         "image"       : "devmode/tableFiltering.png",
         "name"        : "Table Filtering",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/tableFiltering",
         "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/dist/development/examples/tableFiltering/"
     },
+    {
+        "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
+        "environments": ["Desktop"],
+        "id"          : 8,
+        "image"       : "devmode/dragdrop.png",
+        "name"        : "Dialog drag&drop",
+        "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/dialog",
+        "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/dist/development/examples/dialog/"
+    },
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
diff --git a/apps/website/data/examples_dist_prod.json b/apps/website/data/examples_dist_prod.json
@@ -2,7 +2,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 14,
+        "id"          : 15,
         "image"       : "devmode/calendar-preview.png",
         "name"        : "Calendar Sneak Preview",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/src/calendar",
@@ -11,7 +11,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 13,
+        "id"          : 14,
         "image"       : "devmode/covidDashboard.png",
         "name"        : "Covid Dashboard",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/covid",
@@ -20,7 +20,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 12,
+        "id"          : 13,
         "image"       : "devmode/realworldApp.png",
         "name"        : "RealWorld App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/realworld",
@@ -29,7 +29,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 11,
+        "id"          : 12,
         "image"       : "devmode/coronaGallery.png",
         "name"        : "COVID-19 Gallery",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaGallery",
@@ -38,7 +38,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
-        "id"          : 10,
+        "id"          : 11,
         "image"       : "devmode/coronaHelix.png",
         "name"        : "COVID-19 Helix",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/component/coronaHelix",
@@ -47,7 +47,7 @@
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop", "Mobile"],
-        "id"          : 9,
+        "id"          : 10,
         "image"       : "devmode/website.png",
         "name"        : "Neo Website App",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/apps/website",
@@ -56,12 +56,21 @@
     {
         "browsers"    : ["Chrome"],
         "environments": ["Desktop"],
-        "id"          : 8,
+        "id"          : 9,
         "image"       : "devmode/tableFiltering.png",
         "name"        : "Table Filtering",
         "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/tableFiltering",
         "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/dist/production/examples/tableFiltering/"
     },
+    {
+        "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
+        "environments": ["Desktop"],
+        "id"          : 8,
+        "image"       : "devmode/dragdrop.png",
+        "name"        : "Dialog drag&drop",
+        "sourceUrl"   : "https://github.com/neomjs/neo/tree/dev/examples/dialog",
+        "url"         : "https://neomjs.github.io/pages/node_modules/neo.mjs/dist/production/examples/dialog/"
+    },
     {
         "browsers"    : ["Chrome", "Edge", "Firefox", "Safari"],
         "environments": ["Desktop"],
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "neo.mjs",
-    "version": "1.3.51",
+    "version": "1.3.53",
     "description": "The webworkers driven UI framework",
     "repository": {
         "type": "git",
diff --git a/resources/scss/src/dialog/_Base.scss b/resources/scss/src/dialog/_Base.scss
@@ -63,7 +63,10 @@
             .neo-panel-header-text {
                 color         : v(dialog-header-color);
                 pointer-events: none;
+                user-drag     : none; // not supported yet
                 user-select   : none;
+
+                -webkit-user-drag: none;
             }
         }
     }
diff --git a/src/component/Label.mjs b/src/component/Label.mjs
@@ -29,7 +29,8 @@ class Label extends Component {
          * @member {Object} _vdom={tag: 'label'}
          */
         _vdom: {
-            tag: 'label'
+            tag      : 'label',
+            draggable: false
         }
     }}
 
diff --git a/src/main/DomEvents.mjs b/src/main/DomEvents.mjs
@@ -242,7 +242,7 @@ class DomEvents extends Base {
     }
 
     getEventData(event) {
-        let path = event.path || event.composedPath(); // FF does not support composedPath()
+        let path = event.path || event.composedPath(); // FF does not support path
 
         return {
             path     : path.map(e => this.getTargetData(e)),
diff --git a/src/main/addon/DragDrop.mjs b/src/main/addon/DragDrop.mjs
@@ -111,14 +111,16 @@ class DragDrop extends Base {
      * @returns {Object}
      */
     getEventData(event) {
+        const path = event.path || event.composedPath();
+
         const e = {
             ...DomEvents.getEventData(event.detail.originalEvent),
             clientX: event.detail.clientX,
             clientY: event.detail.clientY
         };
 
-        e.targetPath = e.path;
-        e.path       = event.path.map(e => DomEvents.getTargetData(e))
+        e.targetPath = e.path || e.composedPath();
+        e.path       = path.map(e => DomEvents.getTargetData(e))
 
         return e;
     }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "neo.mjs",`
`3`		`- "version": "1.3.51",`
	`3`	`+ "version": "1.3.53",`
`4`	`4`	`"description": "The webworkers driven UI framework",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,10 @@`
`63`	`63`	`.neo-panel-header-text {`
`64`	`64`	`color : v(dialog-header-color);`
`65`	`65`	`pointer-events: none;`
	`66`	`+ user-drag : none; // not supported yet`
`66`	`67`	`user-select : none;`
	`68`	`+`
	`69`	`+ -webkit-user-drag: none;`
`67`	`70`	`}`
`68`	`71`	`}`
`69`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ class Label extends Component {`
`29`	`29`	`* @member {Object} _vdom={tag: 'label'}`
`30`	`30`	`*/`
`31`	`31`	`_vdom: {`
`32`		`- tag: 'label'`
	`32`	`+ tag : 'label',`
	`33`	`+ draggable: false`
`33`	`34`	`}`
`34`	`35`	`}}`
`35`	`36`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ class DomEvents extends Base {`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`getEventData(event) {`
`245`		`- let path = event.path \|\| event.composedPath(); // FF does not support composedPath()`
	`245`	`+ let path = event.path \|\| event.composedPath(); // FF does not support path`
`246`	`246`
`247`	`247`	`return {`
`248`	`248`	`path : path.map(e => this.getTargetData(e)),`