Fix Semantic Version Comparison in HealthService using 'semver' #7584

Author: tobiu

.github/ISSUE/ticket-fix-version-comparison.md

@@ -0,0 +1,24 @@
+---
+title: "Fix Semantic Version Comparison in HealthService using 'semver'"
+labels: bug, AI
+---
+
+GH ticket id: #7584
+
+**Epic:** #7564
+**Phase:** 1
+**Assignee:** tobiu
+**Status:** To Do
+
+## Description
+
+The `HealthService.#checkGhVersion()` method currently uses string comparison (`>=`) to check if the installed `gh` CLI version meets the minimum requirement. This is a critical bug that breaks for semantic versioning (e.g., "2.9.0" incorrectly compares as greater than "2.10.0").
+
+This will be fixed by incorporating the official `semver` npm package.
+
+## Acceptance Criteria
+
+1.  The `semver` package is added as a `devDependency` to `package.json`.
+2.  `npm install` is run to update the `node_modules` directory.
+3.  `HealthService.mjs` is updated to import the `semver` package.
+4.  The `#checkGhVersion()` method is refactored to use `semver.gte(currentVersion, minVersion)` for the version comparison instead of the incorrect string comparison.

ai/mcp/server/github-workflow/services/HealthService.mjs

@@ -2,6 +2,7 @@ import {exec}      from 'child_process';
 import {promisify} from 'util';
 import aiConfig    from '../../config.mjs';
 import Base        from '../../../../../src/core/Base.mjs';
+import semver      from 'semver';
 
 const execAsync = promisify(exec);
 
@@ -40,14 +41,16 @@ class HealthService extends Base {
             const versionMatch = stdout.match(/gh version ([\d.]+)/);
             if (versionMatch) {
                 const currentVersion = versionMatch[1];
-                if (currentVersion >= aiConfig.githubWorkflow.minGhVersion) {
+                const minVersion     = aiConfig.githubWorkflow.minGhVersion;
+
+                if (semver.gte(currentVersion, minVersion)) {
                     return {installed: true, versionOk: true, version: currentVersion};
                 } else {
                     return {
                         installed: true,
                         versionOk: false,
                         version  : currentVersion,
-                        error    : `gh version (${currentVersion}) is outdated. Please upgrade to at least ${aiConfig.githubWorkflow.minGhVersion}.`
+                        error    : `gh version (${currentVersion}) is outdated. Please upgrade to at least ${minVersion}.`
                     };
                 }
             }

package-lock.json

@@ -124,6 +124,7 @@
         "parse5"                       : "^8.0.0",
         "postcss"                      : "^8.5.6",
         "sass"                         : "^1.93.2",
+        "semver"                       : "^7.5.4",
         "siesta-lite"                  : "5.5.2",
         "terser"                       : "^5.44.0",
         "url"                          : "^0.11.4",