Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Resource Stop loading if the Jar isn't a file/jar #1670

Open
Speiger opened this issue Nov 7, 2024 · 0 comments
Open

Server Resource Stop loading if the Jar isn't a file/jar #1670

Speiger opened this issue Nov 7, 2024 · 0 comments
Labels
triage Needs triaging and confirmation

Comments

@Speiger
Copy link
Contributor

Speiger commented Nov 7, 2024

(Sorry for the ramble in the beginning, this issue has been driving me crazy)

This has been an issue with forge until 1.20.0 from what it looks like.
But since minecraft integrated the resource pack cache system it looks like this issue was transferred to there.

Anyways. I am reporting this issue here because i kinda don't know where else to report.
I can't reproduce it but i see that the code for this exact same and that's easily proven, issue is mojang doesn't accept that.
(VanillaPackResourcesBuilder#ROOT_DIR_BY_TYPE is the issue with this problem)

Anyways what is the issue.

I got a bugreport where server translations simply didn't load for 1.20.1 and for 1.19.2.

I checked out their logs and my code since i am almost breaking down to figure out what the issue is and this line made me go hmmmm.

[08нояб.2024 00:35:14.080] [main/WARN] [net.minecraft.server.packs.VanillaPackResources/]: Assets URL 'union:/D:/GanjaCraft/Ganja3%20server/server/libraries/net/minecraft/server/1.19.2-20220805.130853/server-1.19.2-20220805.130853-srg.jar%23103!/assets/.mcassetsroot' uses unexpected schema

For some reason when the URI isn't a "file" "jar" minecraft simply discards the path as valid path and server side resources are simply not being loaded... Translation specifically...
(VanillaPackResourcesBuilder#ROOT_DIR_BY_TYPE is the class for 1.20.0->1.21.x, and Forges cache builder for 1.19.2 but i don't expect a fix for that)

Anyways after realizing this.
Since neoforge does patches for vanilla sometimes, i was wondering. Would you consider fixing that issue?
Since it can affect mods as well.

Here are the logs for either of them.
latest.log debug.log

Anyways, thanks for reading...

@Speiger Speiger added the triage Needs triaging and confirmation label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

1 participant