Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Missing textures in model neoforge:bucket_milk#inventory: #1641

Open
Lolothepro opened this issue Oct 28, 2024 · 1 comment
Open
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error rendering Related to rendering

Comments

@Lolothepro
Copy link
Contributor

Minecraft Version: 1.21.3

NeoForge Version: 21.3.4-beta

Logs: https://mclo.gs/m9nrSbZ

Steps to Reproduce:

  1. Load the game
  2. Check the log file

Description of issue:

[Worker-Main-5/WARN] [minecraft/ModelManager]: Missing textures in model neoforge:bucket_milk#inventory:
    minecraft:textures/atlas/blocks.png:neoforge:items/bucket_base
    minecraft:textures/atlas/blocks.png:neoforge:items/bucket_cover
    minecraft:textures/atlas/blocks.png:neoforge:items/bucket_fluid

NeoForge causes this warning

@Lolothepro Lolothepro added the triage Needs triaging and confirmation label Oct 28, 2024
@sciwhiz12 sciwhiz12 added bug A bug or error rendering Related to rendering 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 2, 2024
@sciwhiz12
Copy link
Member

The area around those model files for the milk buckets and dynamic buckets (as I understand it) needs quite a bit of attention for cleanup.

The textures originally refered from neoforge:bucket_milk are different from the mask textures now present in the assets folder; see https://github.com/neoforged/NeoForge/tree/4ea73399de818f3670a78a5afd5772a05a73221d/src/main/resources/assets/forge/textures/items for the original textures that the model referred to.

Some of these models also need some investigation: why do we duplicate item/generated and item/handheld as neoforge:item/default and neoforge:item/default-tool? Are these models even used at the moment?

The models ought to be moved to datageneration, with comments on why they exist as well for future reference.

@sciwhiz12 sciwhiz12 removed the triage Needs triaging and confirmation label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error rendering Related to rendering
Projects
None yet
Development

No branches or pull requests

2 participants