[1.21.3] Fix BlockParticleOption#pos not getting sent to the client #1673
Conversation
… on NF->NF connections
XFactHD
added
bug
Last commit published: ad7c54bdcef2375c7007c900feb0a8b4a3f1db6b. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1673' // https://github.com/neoforged/NeoForge/pull/1673
url 'https://prmaven.neoforged.net/NeoForge/pr1673'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1673
cd NeoForge-pr1673
curl -L https://prmaven.neoforged.net/NeoForge/pr1673/net/neoforged/neoforge/21.3.14-beta-pr-1673-particleoptions_pos_networking/mdk-pr1673.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
|
@XFactHD, this PR introduces breaking changes.
|
This PR fixes the
BlockParticleOption#posfield not getting sent to the client, causing custom models withModelData-sensitive particle texture selection to be unable to fall back to a default value due to receivingModelData.EMPTY.To fix this, the
StreamCodecofBlockParticleOptionis patched to send the position on NeoForge->NeoForge connections.Vanilla compatibility being retained was tested by connecting with a vanilla client to a NeoForge dev server and falling onto blocks from a sufficient height.
I also opted to slightly clean up the patches around the addition of the position data.
Fixes #1629