Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities pushed by lava move more quickly than in vanilla #1575

Open
2No2Name opened this issue Oct 1, 2024 · 3 comments · May be fixed by #1586
Open

Entities pushed by lava move more quickly than in vanilla #1575

2No2Name opened this issue Oct 1, 2024 · 3 comments · May be fixed by #1586
Labels
bug A bug or error

Comments

@2No2Name
Copy link

2No2Name commented Oct 1, 2024

Minecraft Version: 1.21.1

NeoForge Version: 21.1.65

Logs: Probably not helpful here

Steps to Reproduce:

  1. Create new void world and build this above the starting platform (Command block behind button: summon wither_skeleton ~ ~-3 ~ , other command blocks: time query gametime) Do not spawn the wither skeleton by hand.
    image
  2. Press the button
  3. Wait until the skeleton reaches the pressure plate. Calculate the difference between the times printed in the time query gametime command blocks. Kill the wither skeleton.
  4. Repeat this a few times to convince yourself that you keep measuring the same time difference
  5. Notice that if you perform steps 1-4 in vanilla, the time difference you are getting is 508 ticks. However, with neoforge it is 465 ticks.

Description of issue:
The wither skeleton moves faster in lava when the neoforge mod loader is used. No mods are installed.

@2No2Name 2No2Name added the triage Needs triaging and confirmation label Oct 1, 2024
@2No2Name
Copy link
Author

2No2Name commented Oct 2, 2024

Code investigation shows that neoforge processes lava fluid pushing whenever vanilla only performs water pushing (e.g. when a mob lands on ground).

@2No2Name 2No2Name changed the title Wither skeletons pushed by lava move more quickly than in vanilla Entities pushed by lava move more quickly than in vanilla Oct 3, 2024
@embeddedt
Copy link
Member

Thanks for the code analysis.

@embeddedt embeddedt added bug A bug or error and removed triage Needs triaging and confirmation labels Oct 6, 2024
@2No2Name
Copy link
Author

There is work being done on this code, but I don't think that adresses this issue: https://github.com/neoforged/NeoForge/pull/1586/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants