Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.x] Make RenderPlayerEvent subclass RenderLivingEvent #1304

Open
wants to merge 2 commits into
base: 1.21.x
Choose a base branch
from

Conversation

dhyces
Copy link
Contributor

@dhyces dhyces commented Jul 13, 2024

Closes #1266

Shouldn't introduce breaking changes other than binary breaks. Also took the opportunity to clean up some of the docs that referenced now removed features, like GenericEvents and HasResult, and renamed "Forge event bus" references to "game event bus".

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Jul 13, 2024

@dhyces, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: fd90f489c0df3307aba250338fb12e147790220c.

neoforge (:neoforge)

  • net/neoforged/neoforge/client/event/RenderPlayerEvent
    • ❗ Class missing superclass of net/neoforged/neoforge/event/entity/player/PlayerEvent

@XFactHD XFactHD added rendering Related to rendering breaking change Breaks binary compatibility 1.21 Targeted at Minecraft 1.21 labels Jul 13, 2024
@TelepathicGrunt TelepathicGrunt added 1.21.1 Targeted at Minecraft 1.21.1 and removed 1.21 Targeted at Minecraft 1.21 labels Jul 24, 2024
@TelepathicGrunt
Copy link
Contributor

Putting a 1.21.1 tag on this PR. It is a bit too late now to move events around. We can revisit this PR on next breaking mc version. Or if you adjust this PR to only be javadoc cleanup, we can merge that and have an issue report or something to do the event moving in future mc version

@dhyces
Copy link
Contributor Author

dhyces commented Jul 24, 2024

Understandable. I don't think the jdoc changes are important enough to warrant a separate PR just for these two classes. imo, they should either be fixed in bulk or modified when the classes are changed.

@dhyces dhyces changed the title [1.21] Make RenderPlayerEvent subclass RenderLivingEvent [Future BC Window] Make RenderPlayerEvent subclass RenderLivingEvent Aug 5, 2024
@dhyces dhyces changed the title [Future BC Window] Make RenderPlayerEvent subclass RenderLivingEvent [1.21.x] Make RenderPlayerEvent subclass RenderLivingEvent Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 breaking change Breaks binary compatibility rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21] Make RenderPlayerEvent subclass RenderLivingEvent instead of PlayerEvent
3 participants