Custom Dimension Teleportation

[JCS-Mecabricks]

I am modding with Neoforge and I am making a custom dimension but I can't get to it. I tried making it so that when you right click on a block it teleports you there but instead, it teleported me on the block. I would appreciate it if someone knew how to fix it.

[TelepathicGrunt]

The ServerPlayer has a teleport method that takes a destination dimension. Try and use that. Basically you have to use a method that doesn’t take just a blockposition but a dimension as well

[JCS-Mecabricks]

I don't see an option for changing dimensions.

[JCS-Mecabricks]

package github.jcsmecabricks.redwoodvariants.block.custom;

import github.jcsmecabricks.redwoodvariants.worldgen.dimension.ModDimensions;
import net.minecraft.BlockUtil;
import net.minecraft.core.BlockPos;
import net.minecraft.core.Direction;
import net.minecraft.resources.ResourceKey;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityDimensions;
import net.minecraft.world.entity.Relative;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.level.GameRules;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Portal;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.block.state.properties.BlockStateProperties;
import net.minecraft.world.level.block.state.properties.EnumProperty;
import net.minecraft.world.level.border.WorldBorder;
import net.minecraft.world.level.dimension.DimensionType;
import net.minecraft.world.level.portal.PortalShape;
import net.minecraft.world.level.portal.TeleportTransition;
import net.minecraft.world.phys.Vec3;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

import java.util.Optional;

public class ModPortalBlock extends Block implements Portal {
public static final EnumProperty<Direction.Axis> AXIS = EnumProperty.create("axis", Direction.Axis.class);
public ModPortalBlock(Properties pProperties) {
super(pProperties);
}

protected void entityInside(@NotNull BlockState state, @NotNull Level level, @NotNull BlockPos pos, Entity entity) {
    if (entity.canUsePortal(false)) {
        entity.setAsInsidePortal(this, pos);
    }

}

public int getPortalTransitionTime(@NotNull ServerLevel p_350689_, @NotNull Entity p_350280_) {
    int var10000;
    if (p_350280_ instanceof Player player) {
        var10000 = Math.max(0, p_350689_.getGameRules().getInt(player.getAbilities().invulnerable ? GameRules.RULE_PLAYERS_NETHER_PORTAL_CREATIVE_DELAY : GameRules.RULE_PLAYERS_NETHER_PORTAL_DEFAULT_DELAY));
    } else {
        var10000 = 0;
    }

    return var10000;
}

@Override
public @Nullable TeleportTransition getPortalDestination(ServerLevel p_350444_, @NotNull Entity p_350334_, @NotNull BlockPos p_350764_) {
    ResourceKey<Level> resourcekey = p_350444_.dimension() == ModDimensions.REDWOODDIM_LEVEL_KEY ? Level.OVERWORLD : ModDimensions.REDWOODDIM_LEVEL_KEY;
    ServerLevel serverlevel = p_350444_.getServer().getLevel(resourcekey);
    if (serverlevel == null) {
        return null;
    } else {
        boolean flag = serverlevel.dimension() == ModDimensions.REDWOODDIM_LEVEL_KEY;
        WorldBorder worldborder = serverlevel.getWorldBorder();
        double d0 = DimensionType.getTeleportationScale(p_350444_.dimensionType(), serverlevel.dimensionType());
        BlockPos blockpos = worldborder.clampToBounds(p_350334_.getX() * d0, p_350334_.getY(), p_350334_.getZ() * d0);
        return this.getExitPortal(serverlevel, p_350334_, p_350764_, blockpos, flag, worldborder);
    }
}

@javax.annotation.Nullable
private TeleportTransition getExitPortal(ServerLevel level, Entity entity, BlockPos pos, BlockPos exitPos, boolean isRedwood, WorldBorder worldBorder) {
    Optional<BlockPos> optional = level.getPortalForcer().findClosestPortalPosition(exitPos, isRedwood, worldBorder);
    BlockUtil.FoundRectangle blockutil$foundrectangle;
    TeleportTransition.PostTeleportTransition teleporttransition$postteleporttransition;
    if (optional.isPresent()) {
        BlockPos blockpos = optional.get();
        BlockState blockstate = level.getBlockState(blockpos);
        blockutil$foundrectangle = BlockUtil.getLargestRectangleAround(blockpos, blockstate.getValue(BlockStateProperties.HORIZONTAL_AXIS), 21, Direction.Axis.Y, 21, (p_351970_) -> level.getBlockState(p_351970_) == blockstate);
        teleporttransition$postteleporttransition = TeleportTransition.PLAY_PORTAL_SOUND.then((p_351967_) -> p_351967_.placePortalTicket(blockpos));
    } else {
        Direction.Axis direction$axis = entity.level().getBlockState(pos).getOptionalValue(AXIS).orElse(Direction.Axis.X);
        Optional<BlockUtil.FoundRectangle> optional1 = level.getPortalForcer().createPortal(exitPos, direction$axis);
        if (optional1.isEmpty()) {
            return null;
        }

        blockutil$foundrectangle = optional1.get();
        teleporttransition$postteleporttransition = TeleportTransition.PLAY_PORTAL_SOUND.then(TeleportTransition.PLACE_PORTAL_TICKET);
    }

    return getDimensionTransitionFromExit(entity, pos, blockutil$foundrectangle, level, teleporttransition$postteleporttransition);
}

private static TeleportTransition getDimensionTransitionFromExit(Entity entity, BlockPos pos, BlockUtil.FoundRectangle rectangle, ServerLevel level, TeleportTransition.PostTeleportTransition postTeleportTransition) {
    BlockState blockstate = entity.level().getBlockState(pos);
    Direction.Axis direction$axis;
    Vec3 vec3;
    if (blockstate.hasProperty(BlockStateProperties.HORIZONTAL_AXIS)) {
        direction$axis = blockstate.getValue(BlockStateProperties.HORIZONTAL_AXIS);
        BlockUtil.FoundRectangle blockutil$foundrectangle = BlockUtil.getLargestRectangleAround(pos, direction$axis, 21, Direction.Axis.Y, 21, (p_351016_) -> entity.level().getBlockState(p_351016_) == blockstate);
        vec3 = entity.getRelativePortalPosition(direction$axis, blockutil$foundrectangle);
    } else {
        direction$axis = Direction.Axis.X;
        vec3 = new Vec3(0.5F, 0.0F, 0.0F);
    }

    return createDimensionTransition(level, rectangle, direction$axis, vec3, entity, postTeleportTransition);
}

private static TeleportTransition createDimensionTransition(ServerLevel level, BlockUtil.FoundRectangle rectangle, Direction.Axis axis, Vec3 offset, Entity entity, TeleportTransition.PostTeleportTransition postTeleportTransition) {
    BlockPos blockpos = rectangle.minCorner;
    BlockState blockstate = level.getBlockState(blockpos);
    Direction.Axis direction$axis = blockstate.getOptionalValue(BlockStateProperties.HORIZONTAL_AXIS).orElse(Direction.Axis.X);
    double d0 = rectangle.axis1Size;
    double d1 = rectangle.axis2Size;
    EntityDimensions entitydimensions = entity.getDimensions(entity.getPose());
    int i = axis == direction$axis ? 0 : 90;
    double d2 = (double)entitydimensions.width() / (double)2.0F + (d0 - (double)entitydimensions.width()) * offset.x();
    double d3 = (d1 - (double)entitydimensions.height()) * offset.y();
    double d4 = (double)0.5F + offset.z();
    boolean flag = direction$axis == Direction.Axis.X;
    Vec3 vec3 = new Vec3((double)blockpos.getX() + (flag ? d2 : d4), (double)blockpos.getY() + d3, (double)blockpos.getZ() + (flag ? d4 : d2));
    Vec3 vec31 = PortalShape.findCollisionFreePosition(vec3, level, entity, entitydimensions);
    return new TeleportTransition(level, vec31, Vec3.ZERO, (float)i, 0.0F, Relative.union(Relative.DELTA, Relative.ROTATION), postTeleportTransition);
}

}

[TelepathicGrunt]

I do not see anything at a glance here that actually teleports the player. Once again, the easiest way to teleport the player is to call the teleport method on the entity itself

Example usage would be:

			entity.teleportTo(
				destinationServerLevel,
				destinationX,
				destinationY,
				destinationZ,
				Set.of(),
				entity.getYRot(),
				entity.getXRot()
			);

You would figure out the destination dimension and position first and then call the teleportTo method. It should work fine for your needs

[JCS-Mecabricks]

It wants me to also put a float yaw, float pitch, and a boolean setCamera.

[TelepathicGrunt]

what minecraft version are you on? Because the code example I showed I took directly from 1.21.1 which shows the pitch/yaw (the entity.getYRot() and entity.getXRot() values) but no setCamera param

[JCS-Mecabricks]

1.21.4. Thanks for your help though.

[TelepathicGrunt]

Have setCamera be true. The TeleportCommand and SpreadPlayersCommand both have it set to true

[JCS-Mecabricks]

can i extend nether portal block?