Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In mathgen.pl::generate_bibtex, the compute_re can be moved out of the loop #13

Open
m00shm00sh opened this issue Feb 28, 2025 · 0 comments · May be fixed by #14
Open

In mathgen.pl::generate_bibtex, the compute_re can be moved out of the loop #13

m00shm00sh opened this issue Feb 28, 2025 · 0 comments · May be fixed by #14

Comments

@m00shm00sh
Copy link

compute_re can be moved out of the loop by setting $rules->{"CITE_LABEL_GIVEN"} to 1 before the loop, recomputing re, then inside the loop setting the hashtable entry to [$clabel].

This has been tested in a local build to not introduce regressions and the issue exists mostly for the sake of attaching to a pull request.
@m00shm00sh m00shm00sh linked a pull request Feb 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mathgen: remove inefficiency in compute_re (#13) m00shm00sh/mathgen
1 participant
@m00shm00sh