Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Intro String To Translation File. #34

Open
pqhf5kd opened this issue Mar 28, 2021 · 2 comments
Open

Move Intro String To Translation File. #34

pqhf5kd opened this issue Mar 28, 2021 · 2 comments
Labels
enhancement New feature or request low priority

Comments

@pqhf5kd
Copy link
Collaborator

pqhf5kd commented Mar 28, 2021

map.php contains an 'Intro' string that is displayed in the sidebar when opening the site for the first time.

map.php should instead contain a variable that is set in each translation file.
@pqhf5kd pqhf5kd added enhancement New feature or request low priority labels Mar 28, 2021
@nekromoff
Copy link
Owner

Probably a good idea. It's kind of legacy leftover.

@nekromoff
Copy link
Owner

But, there is an issue with that: config file is install dependent (customized), translation file is install independent (original). This would make intro non-customizable easily via config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nekromoff @pqhf5kd