24%+15%=100%? (Unpainted areas)

[DerLalo]

I used this tool for a street in my neighbourhood. I took a few meters and painted them red and blue. The created image says: Cars (24%) Pedestrians (15%). What about the rest?

If I paint all the rest black, the result is Cars (11%) Pedestrians (7%) Dead space (82%).

So the must be an issue with unpainted areas! In my opinion, they should either be ignored, so the result for the first image should be Cars (62%) Pedestrians (38%). Or they should be handled as dead space, and the result would be the same as in the second example.

[nekromoff]

Indeed, this is the case. All squares are counted towards 100%, but if some are left unmarked, percentage is not calculated for them. Automatic marking of everything unmarked as dead space probably wouldn't be correct. So for now I would leave it to a user to decide. I am leaving this issue open, if somebody else can come with more ideas on how to address this.

…

On Wed, Jun 28, 2023, 09:55 DerLalo ***@***.***> wrote: I used this tool for a street in my neighbourhood. I took a few meters and painted them red and blue. The created image says: Cars (24%) Pedestrians (15%). What about the rest? [image: Aufstieg_arrogance] <https://user-images.githubusercontent.com/137991233/249394152-2558cbde-2b83-49f8-83b2-15ba25ac9763.png> If I paint all the rest black, the result is Cars (11%) Pedestrians (7%) Dead space (82%). [image: Aufstieg_arrogance2] <https://user-images.githubusercontent.com/137991233/249394199-f4d6d3aa-1434-4010-ab59-79995ea65a08.png> So the must be an issue with unpainted areas! In my opinion, they should either be ignored, so the result for the first image should be Cars (62%) Pedestrians (38%). Or they should be handled as dead space, and the result would be the same as in the second example. — Reply to this email directly, view it on GitHub <#16>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBHPTILTT4YLNOLSQXZNBDXNPPODANCNFSM6AAAAAAZWURATE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[DerLalo]

OK, I found the bug: it's the eraser. I uploaded an empty, square picture, scaled to fit 10x10 tiles. In the first step, I marked 6 lines red. The result is correct, 100% Cars:

But if I delete one line, the result is 82% Cars:

So the erased tiles are still counted and not handled as untouched tiles!

[nekromoff]

Good catch! I might fix it at some point. Until then don't use the eraser tool :-)

…

On Tue, Jul 4, 2023 at 10:09 AM DerLalo ***@***.***> wrote: OK, I found the bug: it's the eraser. I uploaded an empty, square picture, scaled to fit 10x10 tiles. In the first step, I marked 6 lines red. The result is correct, 100% Cars: [image: square1] <https://user-images.githubusercontent.com/137991233/250069279-387dff73-2372-472d-986b-6ad0e7c0e2eb.png> But if I delete one line, the result is 82% Cars: [image: square2] <https://user-images.githubusercontent.com/137991233/250069386-cf846c2a-2820-4086-92d0-550bf1dd986b.png> So the erased tiles are still counted and not handled as untouched tiles! — Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBHPTI7CAAPDYOU3H6KB23XOPFUTANCNFSM6AAAAAAZWURATE> . You are receiving this because you commented.Message ID: ***@***.***>