Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView Screen doesn't update links when navigating MangaDex, but does when sharing #2062

Open
4 tasks done
curche opened this issue Feb 24, 2025 · 0 comments
Open
4 tasks done
Labels
bug Something isn't working staged for next release

Comments

@curche
Copy link
Contributor

curche commented Feb 24, 2025

Steps to reproduce

  1. Open MangaDex and open a manga part of a franchise/series in WebView. I chose Winter 2025 Seasonal entry Ave Mujica
  2. Click on Share link or Open in Browser and see what link is shared.
  3. In Webview, under Relations for Ave Mujica, we see multiple entries. Pick one such entry: I chose Star Beat
  4. Observe whether the url at the top of webview screen changes when the new manga entry is loaded
  5. Once again, try to Share link or Open in Browser and see which link is shared.

Expected behavior

Links change when changing entries and are properly used when sharing or opening in browser

Actual behavior

Link at the top doesn't change. However, the shared links are the correct ones.

Crash logs

No response

Neko version

2.19.4

Android version

Android 13, OneUI 5.1

Device

SM-N770F

Other details

The issue seems to be in the subtitle field of the NekoScaffold used in WebviewScreen at Line 51:

NekoScaffold(
title = title,
subtitle = url,
type = NekoScaffoldType.TitleAndSubtitle,
onNavigationIconClicked = onClose,
navigationIcon = Icons.Filled.Close,
navigationIconLabel = stringResource(id = R.string.close),
actions = {

which isn't using the state.lastLoadedUrl unlike in other portions of the code (like Open in Browser, Share)

This issue might also happen in other SPA websites similar to mangadex. I think I noticed it on MangaPlus links too.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the newest version Latest.
  • I have filled out all of the requested information in this form.
@curche curche added the bug Something isn't working label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working staged for next release
Projects
None yet
Development

No branches or pull requests

2 participants