Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links in README.md, SECURITY.md, and CONTRIBUTING.md #2720

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

blakerosenthal
Copy link
Contributor

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

Hi folks, found a couple broken links while going through some of the getting started materials! I will add more as I find them or open a new PR if this is merged before I do.

@@ -30,4 +30,4 @@ This [blog post by Matthew Rocklin](https://matthewrocklin.com/blog/work/2018/02

[nebari-docs-issues]: https://github.com/nebari-dev/nebari-docs/issues
[nebari-issues]: https://github.com/nebari-dev/nebari/issues
[nebari-community]: https://nebari.dev/docs/community
Copy link
Member

@pavithraes pavithraes Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page syncs from nebari-dev/.github, so your change can be overridden later. Opened a corresponding PR here: nebari-dev/.github#33 :)

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🌻

@pavithraes pavithraes added area: documentation 📖 Improvements or additions to documentation status: approved 💪🏾 This PR has been reviewed and approved for merge labels Sep 17, 2024
@Adam-D-Lewis Adam-D-Lewis merged commit 671f542 into nebari-dev:develop Sep 17, 2024
4 checks passed
@Adam-D-Lewis
Copy link
Member

Thanks @blakerosenthal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants