Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Argo integration #278

Closed
1 task done
dharhas opened this issue Mar 1, 2023 · 6 comments
Closed
1 task done

Improve Argo integration #278

dharhas opened this issue Mar 1, 2023 · 6 comments
Labels
area: integration/Argo type: question 🤔 Further information is requested

Comments

@dharhas
Copy link
Member

dharhas commented Mar 1, 2023

Preliminary Checks

Summary

We need to add basic usage documentation for Argo Workflows.

I recently answered this question on another repo that is trying Nebari + Argo with an example form a recent demo:

asascience-open/nextgen-dmac#30 (comment)

This needs to be cleaned up and added in the appropriate location in the docs.

Two additional non-docs questions:

  • should we consider shipping the argo cli in the base image
  • is there a way to auto set these user specific secrets for each user

Steps to Resolve this Issue

1. Add Argo usage docs to nebari's docs.

@dharhas dharhas changed the title [DOC] - <title> [DOC] - Add Argo Usage docs to appropriate location in docs. Mar 1, 2023
@pavithraes pavithraes added type: question 🤔 Further information is requested and removed type: enhancement 💅🏼 New feature or request labels Mar 2, 2023
@pavithraes
Copy link
Member

Thanks for opening this issue! I've moved over the documentation notes to nebari-dev/nebari#48, where we're tracking Argo-docs. I'll edit this issue to discuss the other two questions.

@pavithraes pavithraes changed the title [DOC] - Add Argo Usage docs to appropriate location in docs. Improve Argo integration Mar 2, 2023
@pavithraes
Copy link
Member

@iameskild @costrouc Do you have thoughts on the questions posed here?

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented May 14, 2023

is there a way to auto set these user specific secrets for each user

The way thay comes to mind is to allow KubeSpawner to impersonate Nebari users (like we do from Keycloak UI), gain an Argo access token for the user, then set it as an env var for the user pod

@kcpevey
Copy link
Contributor

kcpevey commented Jul 28, 2023

The way thay comes to mind is to allow KubeSpawner to impersonate Nebari users (like we do from Keycloak UI), gain an Argo access token for the user, then set it as an env var for the user pod

I believe this has been done. @iameskild can you confirm?

@kcpevey
Copy link
Contributor

kcpevey commented Jul 28, 2023

Consideration of adding the Argo CLI to the base image is now an open issue in the main repo: nebari-dev/nebari-docker-images#83

@pavithraes
Copy link
Member

This is complete :)

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Apr 30, 2024
@github-project-automation github-project-automation bot moved this from Todo 📬 to Done 💪🏾 in 📖 - Documentation Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Argo type: question 🤔 Further information is requested
Projects
Status: Done 💪🏾
Development

No branches or pull requests

4 participants