Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPG + pinentry #86

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Add GPG + pinentry #86

merged 4 commits into from
Sep 18, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Closes nebari-dev/nebari#2000

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@iameskild
Copy link
Member Author

@kcpevey @pavithraes I was able to successfully create a GPG key while using this updated jupyterlab image.

@iameskild iameskild merged commit a7819c6 into main Sep 18, 2023
5 checks passed
@iameskild iameskild deleted the add_gpg branch September 18, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes pavithraes left review comments

@kcpevey kcpevey kcpevey approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GPG to base JupyterLab image
3 participants
@iameskild @kcpevey @pavithraes