Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace singleton pattern with dependency injection #92

Open
hadiidbouk opened this issue Jun 18, 2018 · 2 comments
Open

Replace singleton pattern with dependency injection #92

hadiidbouk opened this issue Jun 18, 2018 · 2 comments
Labels
enhancement General improvement question

Comments

@hadiidbouk
Copy link

hadiidbouk commented Jun 18, 2018

Is there any chance to drop the singleton pattern and use dependency injection ?
Or at least making the code flexible if someone want to use DI with a third library like Dagger

@Steppschuh
Copy link
Contributor

For simplicity, I wouldn't force developers to use dependency injection. Same reason why we don't rely on RxJava in this library, although we use it in our internal projects.

If you can implement optional support for Dagger while maintaining the current pattern, feel free to submit a PR.

@Steppschuh Steppschuh added enhancement General improvement question labels Jun 18, 2018
@hadiidbouk
Copy link
Author

I will see, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvement question
Projects
None yet
Development

No branches or pull requests

2 participants