-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] This does not provide the correct parameters for addEventListener
on new Chrome versions. "Unable to preventDefault inside passive event listener due to target being treated as passive"
#383
Open
Comments
addEventListener
on new Chrome versions. "Unable to preventDefault inside passive event listener due to target being treated as passive"
I have verified that these changes stop this problem from occuring:
and
HOWEVER, browser support is limited. Which means before this parameter can be used, support must first be checked, and if it does not exist, the old parameter should be used. |
addEventListener
on new Chrome versions. "Unable to preventDefault inside passive event listener due to target being treated as passive"addEventListener
on new Chrome versions. "Unable to preventDefault inside passive event listener due to target being treated as passive"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The lib is not checking for passive support and providing the correct parameters if it exists. Google has a blog post on this change: (https://developers.google.com/web/updates/2017/01/scrolling-intervention):
The default behavior is for window, document or body elements is:
window.addEventListener("touchstart", func, {passive: true} );
unless{passive: false}
is passed in explicitly. In this case the lib does not do this.This means if anything down the road wants to preventDefault() the following exception will be thrown:
Unable to preventDefault inside passive event listener due to target being treated as passive
More Info:
Related: quasarframework/quasar#9577
The text was updated successfully, but these errors were encountered: