Skip to content

Commit 9b37202

Browse files
author
Amanda Sullivan
committed
Update qsub t include read_qc option. Update IRMA and Dais containers with no vulnerability conatiners,. update change log
1 parent 738fa5d commit 9b37202

File tree

5 files changed

+19
-7
lines changed

5 files changed

+19
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
- Now maintaining code on cdcgov.
1515
- [PR #10](https://github.com/CDCgov/MIRA-NF/pull/10) - reformat the outputs structure
1616
- [PR #11](https://github.com/CDCgov/MIRA-NF/pull/11) - changes the parquet_files flag to reformat_tables flag. This flag now reformats the report tables into parquet files and csv files.
17+
- [PR #12](https://github.com/CDCgov/MIRA-NF/pull/12) - Restructure so that the readqc subworkflow only runs when the flag `--read_qc` is set to true. Otherwise FastQC and MultiQC will not run.
18+
- [PR #12](https://github.com/CDCgov/MIRA-NF/pull/12) - creating and updating docker containers so that they contain no vulnerabilities.
1719

1820
### Parameters
1921

2022
| Old parameter | New parameter |
2123
| ------------- | ---------------------------- |
2224
| `--reformat_tables`| `--parquet_files` |
25+
| | `--read_qc` |
2326

2427
## v1.1.0 - 2024-09-19
2528

@@ -32,7 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3235
- [PR #21](https://github.com/CDCgov/MIRA-NF/commit/f9ea0bfb933adf5617920a8a046998e4f5ba304d) - add amended_consensus.fasta to email
3336
- [PR #22](https://github.com/CDCgov/MIRA-NF/commit/07f5320ecd2462f62c7b0846fe08fc3dafd94598) - add flag that skips the nf-samplesheet creation step. To use this flag you will have to provide a samplesheet that is described as amd platform format in the usage doc
3437
- [PR #23](https://github.com/CDCgov/MIRA-NF/commit/55c9092dfbbfd9ce639633e38fc49bbda28681af) - added in test profile configuration. Added logos.
35-
- [PR #24](https://github.com/CDCgov/MIRA-NF/commit/c2550c30b44de6cd8b5fe3e0b590a9099bb66a10) - Changed nasme of hpc profile to sge profile. Added slurm profile.
38+
- [PR #24](https://github.com/CDCgov/MIRA-NF/commit/c2550c30b44de6cd8b5fe3e0b590a9099bb66a10) - Changed name of hpc profile to sge profile. Added slurm profile.
3639
- [PR #26](https://github.com/CDCgov/MIRA-NF/commit/6baa9681d0c578093d4e32b1f39249104637b206) - Added the RSV Illumina and RSV ONT workflows.
3740

3841
### Parameters

MIRA_nextflow.sh

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010
#$ -V
1111

1212
usage() {
13-
echo -e "Usage in git cloned CLI: \n bash $0 -d <pth_to_mira-cli> -i <path_to_samplesheet.csv> -o <outdir> -r <run_id> -e <experiment_type> -f <nextflow_profiles> <optional: -p amplicon_library> <optional: -g custom_amplicon_library> <optional: -a reformat_tables> <optional: -c read_counts> <optional: -q processing_q> <optional: -m email_address> <optional: -b irma_config> <optional: -n > " 1>&2
13+
echo -e "Usage in git cloned CLI: \n bash $0 -d <pth_to_mira-cli> -i <path_to_samplesheet.csv> -o <outdir> -r <run_id> -e <experiment_type> -f <nextflow_profiles> <optional: -p amplicon_library> <optional: -g custom_amplicon_library> <optional: -a reformat_tables> <optional: -c read_counts> <optional: -q processing_q> <optional: -m email_address> <optional: -b irma_config> <optional: -k read_qc> <optional: -n > " 1>&2
1414
exit 1
1515
}
1616

1717
# Experiment type options: Flu-ONT, SC2-Spike-Only-ONT, Flu_Illumina, SC2-Whole-Genome-ONT, SC2-Whole-Genome-Illumina
1818
# Primer Schema options: articv3, articv4, articv4.1, articv5.3.2, qiagen, swift, swift_211206
1919

20-
while getopts 'd:i:o:r:e:p:g:f:a:c:q:m:b:na' OPTION; do
20+
while getopts 'd:i:o:r:e:p:g:f:a:c:q:m:b:k:na' OPTION; do
2121
case "$OPTION" in
2222
d) DIRNAME="$OPTARG" ;;
2323
i) INPUT="$OPTARG" ;;
@@ -32,6 +32,7 @@ while getopts 'd:i:o:r:e:p:g:f:a:c:q:m:b:na' OPTION; do
3232
q) PROCESSQ="$OPTARG" ;;
3333
m) EMAIL="$OPTARG" ;;
3434
b) OTHER_IRMA_CONFIG="$OPTARG" ;;
35+
k) READS_QC="$OPTARG" ;;
3536
*) usage ;;
3637
esac
3738
done
@@ -78,6 +79,12 @@ else
7879
OPTIONALARGS6="--email $EMAIL"
7980
fi
8081

82+
if [[ -z "${READS_QC}" ]]; then
83+
OPTIONALARGS7=""
84+
else
85+
OPTIONALARGS7="--read_qc $READS_QC"
86+
fi
87+
8188
# Archive previous run using the summary.xlsx file sent in email
8289
if [ -d "$1/dash-json/" ] && [ -n "${TAR}" ]; then
8390
tar --remove-files -czf ${RUNPATH}/previous_run_$(date -d @$(stat -c %Y ${RUNPATH}/dash-json/) "+%Y%b%d-%H%M%S").tar.gz ${RUNPATH}/*html ${RUNPATH}/*fasta ${RUNPATH}/*txt ${RUNPATH}/*xlsx ${RUNPATH}/IRMA ${RUNPATH}/dash-json
@@ -97,4 +104,5 @@ nextflow run "$DIRNAME"/MIRA-NF/main.nf \
97104
$OPTIONALARGS3 \
98105
$OPTIONALARGS4 \
99106
$OPTIONALARGS5 \
100-
$OPTIONALARGS6
107+
$OPTIONALARGS6 \
108+
$OPTIONALARGS7

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ nextflow run ./main.nf \
166166
--read_qc false (optional)
167167
```
168168

169-
For in house testing (note that the read_qc parameter is not available when using the qsub - default set to false):
169+
For in house testing:
170170

171171
```bash
172172
qsub MIRA_nextflow.sh \
@@ -183,6 +183,7 @@ qsub MIRA_nextflow.sh \
183183
-c <SUBSAMPLED_READ_COUNTS> \ (optional)
184184
-b <OTHER_IRMA_CONFIG> (optional)
185185
-m <EMAIL_ADDRESS> \ (optional)
186+
-k <READ_QC> \ (optional)
186187

187188
```
188189

modules/local/daisribosome.nf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
process DAISRIBOSOME {
22
label 'process_medium'
33

4-
container 'cdcgov/dais-ribosome:v1.5.4'
4+
container 'cdcgov/dais-ribosome:bookworm-test5'
55
containerOptions '--bind ${launchDir}/tmp:/dais-ribosome/workdir --bind ${launchDir}/tmp:/dais-ribosome/lib/sswsort/workdir/'
66

77
input:

modules/local/irma.nf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ process IRMA {
22
tag "${sample}"
33
label 'process_high'
44

5-
container 'cdcgov/irma:latest'
5+
container 'cdcgov/irma:bookworm-test5'
66

77
input:
88
tuple val(sample), path(subsampled_fastq_files), val(irma_custom_0), val(irma_custom_1), val(module)

0 commit comments

Comments
 (0)