fix!: handle changed opnsense api since 22.7.x

Author: Jörg Dreffein

check_opnsense.py

@@ -5,7 +5,7 @@
 # check_opnsense.py - A check plugin for monitoring OPNsense firewalls.
 # Copyright (C) 2018  Nicolai Buchwitz <[email protected]>
 #
-# Version: 0.1.0
+# Version: 0.1.1
 #
 # ------------------------------------------------------------------------------
 # This program is free software; you can redistribute it and/or
@@ -211,18 +211,27 @@ def check_updates(self) -> None:
         url = self.get_url("core/firmware/status")
         data = self.request(url)
 
-        if data["status"] == "ok" and data["status_upgrade_action"] == "all":
+        if (
+            data["status"] == "ok"
+            and data.get("status_upgrade_action", "") == "all"
+            and "updates" in data
+        ):
+            # legacy api call
             count = data["updates"]
 
             self.check_result = CheckState.WARNING
-            self.check_message = "{} pending updates".format(count)
-
-            if data["upgrade_needs_reboot"]:
-                self.check_result = CheckState.CRITICAL
-                self.check_message = "{}. Subsequent reboot required.".format(self.check_message)
+            self.check_message = f"{count} pending updates"
+        elif data["status"] == "update":
+            # api call since 22.7.x
+            self.check_result = CheckState.WARNING
+            self.check_message = data["status_msg"]
         else:
             self.check_message = "System up to date"
 
+        if data["upgrade_needs_reboot"]:
+            self.check_result = CheckState.CRITICAL
+            self.check_message = f"{self.check_message}. Subsequent reboot required."
+
     def __init__(self) -> None:
         self.options = {}
         self.perfdata = []