Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issue with AlbumPlayCountMode normalized #2998

Open
3 tasks done
rombat opened this issue May 5, 2024 · 4 comments
Open
3 tasks done

[Bug]: Issue with AlbumPlayCountMode normalized #2998

rombat opened this issue May 5, 2024 · 4 comments
Labels
bug triage New bug reports that need to be evaluated

Comments

@rombat
Copy link

rombat commented May 5, 2024

I confirm that:

  • I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered
  • I'm using the latest version (your issue may have been fixed already)

Version

0.52.0-SNAPSHOT (544ae90)

Current Behavior

There seems to be a weird issue in some cases, probably due to the fact that sometimes, total tracks for an album is not tagged.

Here's the issue:
image
It says here that the album has been played 54 times.
But when I open the album (which is actually just one track, in this case), here's what I get:
image
The track has been played only 4 times.
My guess is that it's probably due to the fact that the file is tagged like that:
image
without album total track

Expected Behavior

I don't know how it should be handled. I think it's mainly due to the fact that the track is not completely tagged, so it's not really a navidrome issue, but I just wanted to let you know about this

Steps To Reproduce

01 - Symphony no. 7.zip
here's the file, if you want to test it

Environment

- OS: Ubuntu
- Browser: Firefox
- Client: Firefox

How Navidrome is installed?

Docker

Configuration

version: "3"
services:
  navidrome:
    container_name: navidrome
    image: deluan/navidrome:develop
    ports:
      - "4533:4533"
    environment:
      ND_SCANSCHEDULE: "@every 5h"
      ND_LOGLEVEL: info
      ND_BASEURL: ""
      ND_ENABLECOVERANIMATION: "false"
      ND_COVERARTPRIORITY: "embedded, folder.*, cover.*, front.*, external"
      ND_SPOTIFY_ID: REDACTED
      ND_SPOTIFY_SECRET: REDACTED
      ND_LASTFM_APIKEY: REDACTED
      ND_LASTFM_SECRET: REDACTED
      ND_IMAGECACHESIZE: "5GB"
      ND_ENABLESHARING: "true"
      ND_DEFAULTTHEME: "Nord"
      ND_SUBSONICARTISTPARTICIPATIONS: "true"
      ND_PLAYLISTSPATH: "Music/_navidrome_playlists"
      ND_SEARCHFULLSTRING: "true"
      ND_ALBUMPLAYCOUNTMODE: "normalized"
    volumes:
      - "./data:/data"
      - "./data/music:/music:ro"
      
networks:
    default:
        external:
            name: personal-services

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow Navidrome's Code of Conduct
@rombat rombat added bug triage New bug reports that need to be evaluated labels May 5, 2024
@rombat
Copy link
Author

rombat commented May 5, 2024

Actually I'm not that sure that it's due to the fact that there's no total track tag
I have this other weird case (and actually many more, but this is always related to albums with just one track)
image
image
image

@deluan
Copy link
Member

deluan commented May 5, 2024

The total tracks is not used in the normalize calc.

The formula is: play_count / song_count, where play_count is the total play_counts for all songs (the absolute play_count).

Can you set ND_ALBUMPLAYCOUNTMODE=absolute (or remove it from the config) and post the play counts, please?

@rombat
Copy link
Author

rombat commented May 5, 2024

ok, I've changed back to absolute, and it's weird, the playcount is exactly the same
it seems like it's the sum of all the plays of both of these albums (which are actually the same, but not for navidrome, probably due to the title case and/or release date. it's easily fixable):
image
image

36+2 => 38

for this one it's not exactly true
image
image

like I said, it's mostly due to the fact that tags are not consistent I guess

@deluan
Copy link
Member

deluan commented May 7, 2024

like I said, it's mostly due to the fact that tags are not consistent I guess

I don't think so, tags are not used for play counts.

Not sure what is going on. Do you mind sending me a copy of your DB, zipped? If you can, send it to deluan @ navidrome.org. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage New bug reports that need to be evaluated
Projects
None yet
Development

No branches or pull requests

2 participants