Skip to content

Commit ae07595

Browse files
committed
Improve live engines error logging
1 parent 2606768 commit ae07595

File tree

4 files changed

+17
-16
lines changed

4 files changed

+17
-16
lines changed

RELEASES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Released on TBD (UTC).
66
None
77

88
### Internal Improvements
9+
- Improve live engines error logging (will now log all exceptions rather than just `RuntimeError`)
910
- Upgraded `datafusion` crate to v43.0.0 (#2056), thanks @twitu
1011

1112
### Breaking Changes

nautilus_trader/live/data_engine.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,8 @@ async def _run_cmd_queue(self) -> None:
390390
self._execute_command(command)
391391
except asyncio.CancelledError:
392392
self._log.warning("DataCommand message queue canceled")
393-
except RuntimeError as e:
394-
self._log.error(f"RuntimeError: {e}")
393+
except Exception as e:
394+
self._log.error(repr(e))
395395
finally:
396396
stopped_msg = "DataCommand message queue stopped"
397397
if not self._cmd_queue.empty():
@@ -411,8 +411,8 @@ async def _run_req_queue(self) -> None:
411411
self._handle_request(request)
412412
except asyncio.CancelledError:
413413
self._log.warning("DataRequest message queue canceled")
414-
except RuntimeError as e:
415-
self._log.error(f"RuntimeError: {e}")
414+
except Exception as e:
415+
self._log.error(repr(e))
416416
finally:
417417
stopped_msg = "DataRequest message queue stopped"
418418
if not self._req_queue.empty():
@@ -432,8 +432,8 @@ async def _run_res_queue(self) -> None:
432432
self._handle_response(response)
433433
except asyncio.CancelledError:
434434
self._log.warning("DataResponse message queue canceled")
435-
except RuntimeError as e:
436-
self._log.error(f"RuntimeError: {e}")
435+
except Exception as e:
436+
self._log.error(repr(e))
437437
finally:
438438
stopped_msg = "DataResponse message queue stopped"
439439
if not self._res_queue.empty():
@@ -451,8 +451,8 @@ async def _run_data_queue(self) -> None:
451451
self._handle_data(data)
452452
except asyncio.CancelledError:
453453
self._log.warning("Data message queue canceled")
454-
except RuntimeError as e:
455-
self._log.error(f"RuntimeError: {e}")
454+
except Exception as e:
455+
self._log.error(repr(e))
456456
finally:
457457
stopped_msg = "Data message queue stopped"
458458
if not self._data_queue.empty():

nautilus_trader/live/execution_engine.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,8 @@ async def _run_cmd_queue(self) -> None:
398398
self._execute_command(command)
399399
except asyncio.CancelledError:
400400
self._log.warning("Command message queue canceled")
401-
except RuntimeError as e:
402-
self._log.error(f"RuntimeError: {e}")
401+
except Exception as e:
402+
self._log.error(repr(e))
403403
finally:
404404
stopped_msg = "Command message queue stopped"
405405
if not self._cmd_queue.empty():
@@ -419,8 +419,8 @@ async def _run_evt_queue(self) -> None:
419419
self._handle_event(event)
420420
except asyncio.CancelledError:
421421
self._log.warning("Event message queue canceled")
422-
except RuntimeError as e:
423-
self._log.error(f"RuntimeError: {e}")
422+
except Exception as e:
423+
self._log.error(repr(e))
424424
finally:
425425
stopped_msg = "Event message queue stopped"
426426
if not self._evt_queue.empty():

nautilus_trader/live/risk_engine.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,8 @@ async def _run_cmd_queue(self) -> None:
244244
self._execute_command(command)
245245
except asyncio.CancelledError:
246246
self._log.warning("Command message queue canceled")
247-
except RuntimeError as e:
248-
self._log.error(f"RuntimeError: {e}")
247+
except Exception as e:
248+
self._log.error(repr(e))
249249
finally:
250250
stopped_msg = "Command message queue stopped"
251251
if not self._cmd_queue.empty():
@@ -265,8 +265,8 @@ async def _run_evt_queue(self) -> None:
265265
self._handle_event(event)
266266
except asyncio.CancelledError:
267267
self._log.warning("Event message queue canceled")
268-
except RuntimeError as e:
269-
self._log.error(f"RuntimeError: {e}")
268+
except Exception as e:
269+
self._log.error(repr(e))
270270
finally:
271271
stopped_msg = "Event message queue stopped"
272272
if not self._evt_queue.empty():

0 commit comments

Comments
 (0)