Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise column names #50

Open
mmc46 opened this issue Jan 28, 2020 · 2 comments
Open

Standardise column names #50

mmc46 opened this issue Jan 28, 2020 · 2 comments

Comments

@mmc46
Copy link
Contributor

mmc46 commented Jan 28, 2020

neuprint_search() returns columns

 [1] "bodyid"        "name"          "type"          "status"        "voxels"       
 [6] "pre"           "post"          "cropped"       "soma"          "cellBodyFiber"

whereas neuprint_find_neurons() returns

[1] "bodyid"       "bodyname"     "bodytype"     "neuronStatus" "size"         "npre"        
[7] "npost"        "CA(R).pre"    "CA(R).post"  

The latter query was for neurons with inputs in CA(R).

ca.info = neuprint_find_neurons(
  input_ROIs = "CA(R)",
  output_ROIs = NULL,
  all_segments = FALSE # if true, fragments smaller than 'neurons' are returned as well
)
@jefferis
Copy link
Contributor

jefferis commented Feb 6, 2020

@romainFr @alexanderbates I think we should be moving to a new release of the package after which we reduce the rate of churn. Do we think it would be a good idea to implement this change before that?

@romainFr
Copy link
Collaborator

romainFr commented Feb 7, 2020

Yes. I'd be in favor of the neuprint_search convention. Also it would be good to return the same kind of format for the ROI pre and post as neuprint_connection_table (meaning having roi and ROIweight columns instead of the columns named with ROI.pre)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants