Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this possible to depend on a safer version of Google.Protobuf NuGet package? #204

Open
dungpa opened this issue May 31, 2022 · 4 comments

Comments

@dungpa
Copy link
Contributor

dungpa commented May 31, 2022

Currently STAN.Client Nuget package uses Google.Protobuf version 3.13.0 which contains security vulnerabilities.
See e.g.:

It's possible for the downstream systems to pin to a newer version and apply binding redirects.
But it is not ideal for STAN.Client to depend on a compromised version of a popular dependency.

Is this possible to publish a new version of STAN.Client that uses Google.Protobuf 3.15.0 or newer (as suggested by the security advisory above)?

@scottf
Copy link
Contributor

scottf commented May 31, 2022

@dungpa We don't really support this client anymore, but if you make a PR with a fix we probably can merge it.

@dungpa
Copy link
Contributor Author

dungpa commented Jun 11, 2022

@scottf It has been done by Dependabot at #203?

Is there any chance to merge that PR and release a new version of STAN.Client NuGet package?

@scottf
Copy link
Contributor

scottf commented Jun 11, 2022

@dungpa I merged #203 I then noticed that Google.Protobuf and Tools is at 3.21.1. Is it possible that you can upgrade to the latest? We really are not supporting this client anymore because of JetStream, but I can merge things and try to build.

@dungpa
Copy link
Contributor Author

dungpa commented Jun 12, 2022

@scottf I upgraded Google.Protobuf.Tools to 3.15.0 in #205 for consistency.

We are not ready to move to 3.21.1 yet, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants