From b20170f074821087dff030571f82bedddfb06966 Mon Sep 17 00:00:00 2001 From: Hong Chen Date: Mon, 6 Jan 2025 13:31:19 -0600 Subject: [PATCH 1/4] Updated to Github actions v4 as Github actions v3 will be closing down by 1/30/25. --- .github/workflows/report_linux_py2.yml | 2 +- .github/workflows/test_linux.yml | 2 +- .github/workflows/test_macos.yml | 2 +- .github/workflows/trickops.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/report_linux_py2.yml b/.github/workflows/report_linux_py2.yml index 952e4a2a3..74b71e0a7 100644 --- a/.github/workflows/report_linux_py2.yml +++ b/.github/workflows/report_linux_py2.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/test_linux.yml b/.github/workflows/test_linux.yml index 17e587a72..eb07ed2e1 100644 --- a/.github/workflows/test_linux.yml +++ b/.github/workflows/test_linux.yml @@ -146,7 +146,7 @@ jobs: python3 -m venv .venv && . .venv/bin/activate && pip3 install -r requirements.txt cd ../../../; make test - name: Upload Tests - uses: actions/upload-artifact@v3.0.0 + uses: actions/upload-artifact@v4 if: success() || failure() # run this step even if previous step failed with: name: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} diff --git a/.github/workflows/test_macos.yml b/.github/workflows/test_macos.yml index d232eadf0..1a365f79f 100644 --- a/.github/workflows/test_macos.yml +++ b/.github/workflows/test_macos.yml @@ -42,7 +42,7 @@ jobs: export MAKEFLAGS=-j4 cd ../../../; make test - name: Upload Tests - uses: actions/upload-artifact@v3.0.0 + uses: actions/upload-artifact@v4 if: success() || failure() # run this step even if previous step failed with: name: Trick_macos diff --git a/.github/workflows/trickops.yml b/.github/workflows/trickops.yml index bd20eac5e..ff6878c2d 100644 --- a/.github/workflows/trickops.yml +++ b/.github/workflows/trickops.yml @@ -63,7 +63,7 @@ jobs: source ../.venv/bin/activate export PATH="/tmp/koviz-master/bin:${PATH}" ./run_tests.py - - uses: actions/upload-artifact@v3.0.0 + - uses: actions/upload-artifact@v4 if: ${{ always() }} with: name: doctests From 5ea539316345903ed8d9eb29f1fedee4ca64556d Mon Sep 17 00:00:00 2001 From: Hong Chen Date: Tue, 7 Jan 2025 14:06:29 -0600 Subject: [PATCH 2/4] Updated to use actions/checkout action at the v4 branch as well to be consistent with artifacts. It is recommended to use a sepcific version or tag instead of master to ensure stability and predictability. --- .github/workflows/alt_linux_distros.yml | 2 +- .github/workflows/code_coverage.yml | 2 +- .github/workflows/python_tests_linux.yml | 2 +- .github/workflows/python_tests_macos.yml | 2 +- .github/workflows/report_alt_linux_distros.yml | 2 +- .github/workflows/report_linux.yml | 2 +- .github/workflows/report_macos.yml | 2 +- .github/workflows/test_32_oracle.yml | 2 +- .github/workflows/test_linux.yml | 2 +- .github/workflows/test_linux_py2.yml | 4 ++-- .github/workflows/test_macos.yml | 2 +- .github/workflows/trickops.yml | 2 +- 12 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/alt_linux_distros.yml b/.github/workflows/alt_linux_distros.yml index 5583b2354..69223250e 100644 --- a/.github/workflows/alt_linux_distros.yml +++ b/.github/workflows/alt_linux_distros.yml @@ -141,7 +141,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` diff --git a/.github/workflows/code_coverage.yml b/.github/workflows/code_coverage.yml index 32abf3e38..9db3e406b 100644 --- a/.github/workflows/code_coverage.yml +++ b/.github/workflows/code_coverage.yml @@ -32,7 +32,7 @@ jobs: dnf install -y gtest-devel gmock-devel - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Configure Trick run: | diff --git a/.github/workflows/python_tests_linux.yml b/.github/workflows/python_tests_linux.yml index 63b475758..803f90790 100644 --- a/.github/workflows/python_tests_linux.yml +++ b/.github/workflows/python_tests_linux.yml @@ -140,7 +140,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Info after checkout run: | pwd diff --git a/.github/workflows/python_tests_macos.yml b/.github/workflows/python_tests_macos.yml index b0027d273..10e7b8dc5 100644 --- a/.github/workflows/python_tests_macos.yml +++ b/.github/workflows/python_tests_macos.yml @@ -19,7 +19,7 @@ jobs: runs-on: macos-latest steps: - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Install python run: | brew install python diff --git a/.github/workflows/report_alt_linux_distros.yml b/.github/workflows/report_alt_linux_distros.yml index 7ca302cce..57b782251 100644 --- a/.github/workflows/report_alt_linux_distros.yml +++ b/.github/workflows/report_alt_linux_distros.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_linux.yml b/.github/workflows/report_linux.yml index 907dc2b42..bd94b4f6e 100644 --- a/.github/workflows/report_linux.yml +++ b/.github/workflows/report_linux.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_macos.yml b/.github/workflows/report_macos.yml index 03b706c1a..1d1e4fbd5 100644 --- a/.github/workflows/report_macos.yml +++ b/.github/workflows/report_macos.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_macos # artifact name name: Results_Trick_macos # Name of the check run which will be created diff --git a/.github/workflows/test_32_oracle.yml b/.github/workflows/test_32_oracle.yml index c0850e095..b9d23d16d 100644 --- a/.github/workflows/test_32_oracle.yml +++ b/.github/workflows/test_32_oracle.yml @@ -56,7 +56,7 @@ jobs: make make install - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build Trick run: | export CFLAGS="-m32" diff --git a/.github/workflows/test_linux.yml b/.github/workflows/test_linux.yml index eb07ed2e1..1c58ce6e3 100644 --- a/.github/workflows/test_linux.yml +++ b/.github/workflows/test_linux.yml @@ -129,7 +129,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` diff --git a/.github/workflows/test_linux_py2.yml b/.github/workflows/test_linux_py2.yml index ce2ef9bb0..6796a0dbe 100644 --- a/.github/workflows/test_linux_py2.yml +++ b/.github/workflows/test_linux_py2.yml @@ -129,7 +129,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` @@ -145,7 +145,7 @@ jobs: python3 -m venv .venv && . .venv/bin/activate && pip3 install -r requirements.txt cd ../../../; make test - name: Upload Tests - uses: actions/upload-artifact@v3.0.0 + uses: actions/upload-artifact@v4 if: success() || failure() # run this step even if previous step failed with: name: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} diff --git a/.github/workflows/test_macos.yml b/.github/workflows/test_macos.yml index 1a365f79f..5d4fe860c 100644 --- a/.github/workflows/test_macos.yml +++ b/.github/workflows/test_macos.yml @@ -16,7 +16,7 @@ jobs: runs-on: macos-13 steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Install gtest run: | brew install googletest diff --git a/.github/workflows/trickops.yml b/.github/workflows/trickops.yml index ff6878c2d..b4d859b8c 100644 --- a/.github/workflows/trickops.yml +++ b/.github/workflows/trickops.yml @@ -31,7 +31,7 @@ jobs: source ../.venv/bin/activate export PATH="/tmp/koviz-master/bin:${PATH}" ./run_tests.py - - uses: actions/upload-artifact@v3.0.0 + - uses: actions/upload-artifact@v4 if: ${{ always() }} with: name: doctests From c4eecc3bd6292ab6d6f50b4725caffc05b473785 Mon Sep 17 00:00:00 2001 From: Hong Chen Date: Tue, 7 Jan 2025 14:56:35 -0600 Subject: [PATCH 3/4] Made the artifact name unique within the workflow run. --- .github/workflows/trickops.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/trickops.yml b/.github/workflows/trickops.yml index b4d859b8c..71c653639 100644 --- a/.github/workflows/trickops.yml +++ b/.github/workflows/trickops.yml @@ -34,7 +34,7 @@ jobs: - uses: actions/upload-artifact@v4 if: ${{ always() }} with: - name: doctests + name: doctests_${{ github.run_id }}_${{ github.job }} path: | share/trick/trickops/tests/*_doctest_log.txt /tmp/log.* @@ -66,7 +66,7 @@ jobs: - uses: actions/upload-artifact@v4 if: ${{ always() }} with: - name: doctests + name: doctests_${{ github.run_id }}_${{ github.job }} path: | share/trick/trickops/tests/*_doctest_log.txt /tmp/log.* From ebe2244fa53b02afb6a923ffa0211a80ad0310be Mon Sep 17 00:00:00 2001 From: Hong Chen Date: Tue, 14 Jan 2025 17:04:53 -0600 Subject: [PATCH 4/4] Changed CI report workflows test report version back to v1 Changed GitHub action for test report version back to v1 to test if it works for the recent action and artifact version bump (to v4). --- .github/workflows/report_alt_linux_distros.yml | 2 +- .github/workflows/report_linux.yml | 2 +- .github/workflows/report_linux_py2.yml | 2 +- .github/workflows/report_macos.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/report_alt_linux_distros.yml b/.github/workflows/report_alt_linux_distros.yml index 57b782251..7ca302cce 100644 --- a/.github/workflows/report_alt_linux_distros.yml +++ b/.github/workflows/report_alt_linux_distros.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v4 + - uses: dorny/test-reporter@v1 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_linux.yml b/.github/workflows/report_linux.yml index bd94b4f6e..907dc2b42 100644 --- a/.github/workflows/report_linux.yml +++ b/.github/workflows/report_linux.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v4 + - uses: dorny/test-reporter@v1 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_linux_py2.yml b/.github/workflows/report_linux_py2.yml index 74b71e0a7..952e4a2a3 100644 --- a/.github/workflows/report_linux_py2.yml +++ b/.github/workflows/report_linux_py2.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v4 + - uses: dorny/test-reporter@v1 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_macos.yml b/.github/workflows/report_macos.yml index 1d1e4fbd5..03b706c1a 100644 --- a/.github/workflows/report_macos.yml +++ b/.github/workflows/report_macos.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v4 + - uses: dorny/test-reporter@v1 with: artifact: Trick_macos # artifact name name: Results_Trick_macos # Name of the check run which will be created