Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: disp-s1 historical app crashes if a frame's sensing time count is evenly divisible by k #1048

Open
philipjyoon opened this issue Dec 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working needs triage Issue that requires triage

Comments

@philipjyoon
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Describe the bug

We always use k=15. When a DISP-S1 frame contains sensing datetimes in quantity that's a multiple of k (e.g. 15, 30, 45, etc) run_disp_s1_historical_processing.py crashes. This is probably an edge condition that hadn't been anticipated.

What did you expect?

N/A

Reproducible steps

1.
2.
3.
...

Environment

- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...
@philipjyoon philipjyoon added bug Something isn't working needs triage Issue that requires triage labels Dec 27, 2024
@philipjyoon philipjyoon self-assigned this Dec 27, 2024
philipjyoon added a commit that referenced this issue Dec 27, 2024
…as the length; if so, set the frame to be complete. Also a few other minor improvements
hhlee445 added a commit that referenced this issue Jan 8, 2025
…s_fix

#1048: Perform check to see if the sensing datetime position is same …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Issue that requires triage
Projects
None yet
Development

No branches or pull requests

1 participant