Skip to content

Commit 3836380

Browse files
Merge branch 'develop-cli-base' into develop. Close #180.
**Description** The cabal file for `ogma-cli` does not specify version bounds on base, which makes hackage reject the package. **Type** - Bug: Cabal package refused by hackage. **Additional context** None. **Requester** - Ivan Perez. **Method to check presence of bug** Attempting to upload the package to hackage results in an error: ``` Error: Invalid package [missing-bounds-important] The dependency 'build-depends: base' does not specify an upper bound on the version number. Each major release of the 'base' package changes the API in various ways and most packages will need some changes to compile with it. The recommended practice is to specify an upper bound on the version of the 'base' package. This ensures your package will continue to build when a new major version of the 'base' package is released. If you are not sure what upper bound to use then use the next major version. For example if you have tested your package with 'base' version 4.5 and 4.6 then use 'build-depends: base >= 4.5 && < 4.7'. ``` The following grep command finds any references of `base` without any bounds following it (it assumes leading commas in list): ```Dockerfile FROM ubuntu:focal RUN apt-get update RUN apt-get install --yes git SHELL ["/bin/bash", "-c"] CMD git clone $REPO \ && cd $NAME \ && git checkout $COMMIT \ && ! grep -niHre 'base$' ogma-cli/ogma-cli.cabal \ && echo "Success" ``` Command (substitute variables based on new path after merge): ```sh $ docker run -e "REPO=https://github.com/NASA/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=<HASH>" -it ogma-verify-180 ``` **Expected result** All references to `base` in `ogma-cli` include version bounds. **Solution implemented** Add same version bounds to `base` in the test component as in the library. **Further notes** None.
2 parents fef8303 + a94046e commit 3836380

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

ogma-cli/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* Introduce new standalone command (#170).
88
* Update README to demonstrate robotics (#172).
99
* Remove unused resources (#174).
10+
* Add version bounds to base (#180).
1011

1112
## [1.4.1] - 2024-09-21
1213

ogma-cli/ogma-cli.cabal

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ test-suite test-ogma
153153
Main.hs
154154

155155
build-depends:
156-
base
156+
base >= 4.11.0.0 && < 5
157157
, HUnit
158158
, process
159159
, test-framework

0 commit comments

Comments
 (0)