You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge branch 'develop-cli-base' into develop. Close#180.
**Description**
The cabal file for `ogma-cli` does not specify version bounds on base,
which makes hackage reject the package.
**Type**
- Bug: Cabal package refused by hackage.
**Additional context**
None.
**Requester**
- Ivan Perez.
**Method to check presence of bug**
Attempting to upload the package to hackage results in an error:
```
Error: Invalid package
[missing-bounds-important] The dependency 'build-depends: base' does not
specify an upper bound on the version number. Each major release of the 'base'
package changes the API in various ways and most packages will need some
changes to compile with it. The recommended practice is to specify an upper
bound on the version of the 'base' package. This ensures your package will
continue to build when a new major version of the 'base' package is released.
If you are not sure what upper bound to use then use the next major version.
For example if you have tested your package with 'base' version 4.5 and 4.6
then use 'build-depends: base >= 4.5 && < 4.7'.
```
The following grep command finds any references of `base` without any
bounds following it (it assumes leading commas in list):
```Dockerfile
FROM ubuntu:focal
RUN apt-get update
RUN apt-get install --yes git
SHELL ["/bin/bash", "-c"]
CMD git clone $REPO \
&& cd $NAME \
&& git checkout $COMMIT \
&& ! grep -niHre 'base$' ogma-cli/ogma-cli.cabal \
&& echo "Success"
```
Command (substitute variables based on new path after merge):
```sh
$ docker run -e "REPO=https://github.com/NASA/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=<HASH>" -it ogma-verify-180
```
**Expected result**
All references to `base` in `ogma-cli` include version bounds.
**Solution implemented**
Add same version bounds to `base` in the test component as in the library.
**Further notes**
None.
0 commit comments