Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#462] arducam checkout #488

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Conversation

kevincbruce
Copy link
Contributor

Finished updating the Arducam checkout to allow it to take pictures, as that logic was previously incomplete. For this, I modified the device and some config code slightly to make the output location consistent with our current VM and to allow the generation of an actual picture to be toggled on by default in the checkout and off by default (current state in dev) for when cFS is running. Then I replicated the logic from parts of the child task in the partially complete logic for taking pictures in checkout, to allow the reading of the data.

Steps:

Enable Arducam in the NOS3 minimal config, switch to using the minimal config in the top level no3 mission config, and uncomment the Arducam part of checkout.sh in scripts.

make clean
make debug
cd components/arducam/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout

Run the commands and check the picture generated (should be called pic.jpg) and verify it is a picture of someone holding the STF-1 Patch when the picture read is complete. Can also delete the picture file and run with FSW to prove that the picture is not being generated when running FSW due to the new switch in platform_cfg for generating the picture.

The following submodule PRs must be merged and updated first:

nasa-itc/arducam#8

Closes #462

@kevincbruce kevincbruce added the Feature New Feature label Feb 4, 2025
@kevincbruce kevincbruce self-assigned this Feb 4, 2025
@kevincbruce kevincbruce changed the base branch from main to dev February 4, 2025 20:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (746b69a).
Report is 33 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #488   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picture loaded successfully

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to work as intended.

@jlucas9
Copy link
Contributor

jlucas9 commented Feb 8, 2025

Doesn't work if you are not using the default path on Desktop in NOS3. Need to update came_device.c:504 and other hard paths to use local pathing.

@kevincbruce

@kevincbruce
Copy link
Contributor Author

Will do when I get to a computer @jlucas9. How would this best be done? The original was just trying to generate a file, but didn't seem to be anywhere I could find until I did an absolute path.

@jlucas9
Copy link
Contributor

jlucas9 commented Feb 10, 2025

Will do when I get to a computer @jlucas9. How would this best be done? The original was just trying to generate a file, but didn't seem to be anywhere I could find until I did an absolute path.

I think we may be able to just get away with opening a file in the local folder it's running and telling the user to navigate to it.

@kevincbruce kevincbruce merged commit 1e47902 into dev Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arducam Checkout Application
5 participants