Fix static analysis warning in Serializable.cpp (#2385) (#2386)

* Fix bug in Serializable.cpp (#2385)

* Modernize type name

* Update spelling

Author: bocchino

.github/actions/spelling/expect.txt

@@ -785,6 +785,7 @@ ptf
 pthread
 ptmcg
 pton
+ptrt
 puml
 punc
 pushd

Fw/Types/Serializable.cpp

@@ -478,7 +478,13 @@ namespace Fw {
     }
 
     SerializeStatus SerializeBufferBase::deserialize(void*& val) {
-        return this->deserialize(reinterpret_cast<POINTER_CAST&>(val));
+        // Deserialize as pointer cast, then convert to void*
+        PlatformPointerCastType pointerCastVal = 0;
+        const SerializeStatus stat = this->deserialize(pointerCastVal);
+        if (stat == FW_SERIALIZE_OK) {
+            val = reinterpret_cast<void*>(pointerCastVal);
+        }
+        return stat;
     }
 
     SerializeStatus SerializeBufferBase::deserialize(F32 &val) {

Fw/Types/test/ut/TypesTest.cpp

@@ -369,6 +369,23 @@ TEST(SerializationTest,Serialization1) {
 #if DEBUG_VERBOSE
     printf("Val: in: %s out: %s stat1: %d stat2: %d\n",
             boolt1 ? "TRUE" : "FALSE", boolt2 ? "TRUE" : "FALSE", stat1, stat2);
+    printf("Pointer Test\n");
+#endif
+
+    U32 u32Var = 0;
+    void* ptrt1 = &u32Var;
+    void* ptrt2 = nullptr;
+
+    buff.resetSer();
+    stat1 = buff.serialize(ptrt1);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
+    stat2 = buff.deserialize(ptrt2);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
+    ASSERT_EQ(ptrt1,ptrt2);
+
+#if DEBUG_VERBOSE
+    printf("Val: in: %p out: %p stat1: %d stat2: %d\n",
+            ptrt1, ptrt2, stat1, stat2);
 
     printf("Skip deserialization Tests\n");
 #endif
@@ -422,6 +439,7 @@ TEST(SerializationTest,Serialization1) {
     f32t2 = 0.0;
     f64t2 = 0.0;
     boolt2 = false;
+    ptrt2 = nullptr;
 
     buff.resetSer();
     stat1 = buff.serialize(u8t1);
@@ -446,6 +464,8 @@ TEST(SerializationTest,Serialization1) {
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
     stat1 = buff.serialize(boolt1);
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
+    stat1 = buff.serialize(ptrt1);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
 
     // TKC - commented out due to fprime-util choking on output
     // std::cout << "Buffer contents: " << buff << std::endl;
@@ -474,6 +494,8 @@ TEST(SerializationTest,Serialization1) {
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
     stat1 = buff2.serialize(boolt1);
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
+    stat1 = buff2.serialize(ptrt1);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat1);
 
     ASSERT_EQ(buff,buff2);
 
@@ -512,6 +534,9 @@ TEST(SerializationTest,Serialization1) {
     stat2 = buff.deserialize(boolt2);
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
     ASSERT_EQ(boolt1,boolt2);
+    stat2 = buff.deserialize(ptrt2);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
+    ASSERT_EQ(ptrt1,ptrt2);
 
 // reset and deserialize again
 #if DEBUG_VERBOSE
@@ -531,6 +556,7 @@ TEST(SerializationTest,Serialization1) {
     f32t2 = 0.0;
     f64t2 = 0.0;
     boolt2 = false;
+    ptrt2 = nullptr;
 
     stat2 = buff.deserialize(u8t2);
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
@@ -565,6 +591,9 @@ TEST(SerializationTest,Serialization1) {
     stat2 = buff.deserialize(boolt2);
     ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
     ASSERT_EQ(boolt1,boolt2);
+    stat2 = buff.deserialize(ptrt2);
+    ASSERT_EQ(Fw::FW_SERIALIZE_OK,stat2);
+    ASSERT_EQ(ptrt1,ptrt2);
 
     // serialize string
     Fw::String str1;