Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpp-to-cpp generates a DP Receive handler when it shouldn't #594

Closed
bocchino opened this issue Feb 3, 2025 · 1 comment
Closed

fpp-to-cpp generates a DP Receive handler when it shouldn't #594

bocchino opened this issue Feb 3, 2025 · 1 comment
Assignees
@bocchino
Milestone
v2.3.0

Comments

@bocchino
Copy link
Collaborator

bocchino commented Feb 3, 2025 •
edited
Loading

When there is a dpGet port but no dpReceive port, fpp-to-cpp should not generate the pure virtual DP Receive handler.
@bocchino bocchino added this to the v2.3.0 milestone Feb 3, 2025
@bocchino bocchino self-assigned this Feb 3, 2025
@bocchino bocchino moved this from To do to In progress in FPP Fixes and Enhancements Feb 3, 2025
@bocchino bocchino mentioned this issue Feb 3, 2025
Merged
@bocchino
Copy link
Collaborator Author

bocchino commented Feb 5, 2025

Done in #596.

@bocchino bocchino closed this as completed Feb 5, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in FPP Fixes and Enhancements Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bocchino bocchino

Labels
None yet
Projects
FPP Fixes and Enhancements
Status: Done
Milestone
v2.3.0
Development

No branches or pull requests
1 participant
@bocchino