-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use keyword signature in CMakeLists #12
Comments
Can you send a PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CMake reported an error when compiling a project using this repository as a dependency:
It seems like the error was caused by this like in
CMakeLists.txt
, which uses the plain (noPUBLIC
/PRIVATE
)target_link_libraries
statement.quickjs-build/CMakeLists.txt
Line 51 in a516a78
Changing it to
target_link_libraries(qjs PRIVATE atomic)
seems to fix the problem.Environment:
The text was updated successfully, but these errors were encountered: