Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add --partition-tag option to "modkit extract calls" #356

Open
zaka-edd opened this issue Jan 28, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@zaka-edd
Copy link

Currently, the --partition-tag option is available for the modkit pileup command, allowing users to partition output into multiple bedMethyl files based on tag-value pairs. It would be beneficial to have a similar functionality for the modkit extract calls command.

Is this feature technically feasible given the current architecture of modkit? If so could it be added? if not do you have any suggestions on how to get similar output.

Thank you in advance for your time

@ArtRand
Copy link
Contributor

ArtRand commented Jan 28, 2025

Hello @zaka-edd,

I'm right in the middle of some requested updates to modkit extract calls, one thing is adding BAM Aux tag information. I don't know if it will make sense to partition the output files like pileup does, but instead have a column that can be filtered on. I'm also adding different output data formats to make slicing-and-dicing the tables faster and easier. Do you think having a column with the HP tag would address your use case?

@ArtRand ArtRand added the enhancement New feature or request label Jan 28, 2025
@zaka-edd
Copy link
Author

Hey @ArtRand,

Thank you for the quick answer. I am still experimenting with some stuff, but If possible, having an HP column would work well for me, and I could handle the splitting myself. Otherwise, if it’s not too much work, partitioning the output similar to pileup would also be useful. Either option would help with my use case.

Thanks again for the work you’re putting into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants