We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please note the discrepancy highlighted in the screenshot above.
Is it right to assume we don't want to change anything in our decodeDNSPacketBytes implementation?
decodeDNSPacketBytes
Assuming so, perhaps the fix here is just to change:
it("should return [null, null] for labels with unindexable characters", () => {
to:
it("should return [null, null] for labels with unindexable characters (except the empty label)", () => {
Advice appreciated 👍
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Please note the discrepancy highlighted in the screenshot above.
Is it right to assume we don't want to change anything in our
decodeDNSPacketBytesimplementation?Assuming so, perhaps the fix here is just to change:
it("should return [null, null] for labels with unindexable characters", () => {to:
it("should return [null, null] for labels with unindexable characters (except the empty label)", () => {Advice appreciated 👍
The text was updated successfully, but these errors were encountered: