Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index labels with null bytes #45

Open
Tracked by #137
lightwalker-eth opened this issue Jan 21, 2025 · 1 comment
Open
Tracked by #137

Index labels with null bytes #45

lightwalker-eth opened this issue Jan 21, 2025 · 1 comment
Labels
enhancement New feature or request ensnode ENSNode related
Milestone
v2+

Comments

@lightwalker-eth
Copy link
Member

lightwalker-eth commented Jan 21, 2025 •
edited
Loading

This feature would break backwards compatibility with the ENS Subgraph. Added to v2+ milestone.

Related background:

  1. Subgraph Logic Fixes Post 21M Diff #38 (comment)
  2. https://github.com/namehash/ensnode/pull/38/files#r1923518584

Ideally all labels with null bytes (or that otherwise are "unindexable labels") should still be indexed, but indexed such that they are represented as unknown labels.
@lightwalker-eth lightwalker-eth added the enhancement New feature or request label Jan 21, 2025
@lightwalker-eth lightwalker-eth added this to the v2 milestone Jan 21, 2025
@lightwalker-eth lightwalker-eth mentioned this issue Jan 21, 2025
Merged
@lightwalker-eth lightwalker-eth changed the title Enhance support for labels with null bytes Index labels with null bytes Jan 21, 2025
@lightwalker-eth lightwalker-eth moved this to Backlog in ENSNode Jan 22, 2025
@lightwalker-eth
Copy link
Member Author

Related issue with discussion: ponder-sh/ponder#1456

@lightwalker-eth lightwalker-eth mentioned this issue Jan 31, 2025
Open
15 tasks
@lightwalker-eth lightwalker-eth added the ensnode ENSNode related label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ensnode ENSNode related
Projects
ENSNode
Status: Backlog
Milestone
v2+
Development

No branches or pull requests
1 participant
@lightwalker-eth