Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine decodeDNSPacketBytes #41

Open
lightwalker-eth opened this issue Jan 21, 2025 · 0 comments
Open

Refine decodeDNSPacketBytes #41

lightwalker-eth opened this issue Jan 21, 2025 · 0 comments
Assignees
@shrugs
Labels
documentation Improvements or additions to documentation ensnode ENSNode related
Milestone
v2+

Comments

@lightwalker-eth
Copy link
Member

This issue is a reference to decodeDNSPacketBytes in src/lib/subname-helpers.ts.

Ideally we would refine the return type here so that it is a named type / interface, where each field / array index is documented for what it represents. We should also document what a null value represents in each field.
@lightwalker-eth lightwalker-eth mentioned this issue Jan 21, 2025
Merged
@lightwalker-eth lightwalker-eth added this to the v2 milestone Jan 21, 2025
@lightwalker-eth lightwalker-eth added the documentation Improvements or additions to documentation label Jan 21, 2025
@lightwalker-eth lightwalker-eth moved this to Backlog in ENSNode Jan 22, 2025
@lightwalker-eth lightwalker-eth added the ensnode ENSNode related label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrugs shrugs

Labels
documentation Improvements or additions to documentation ensnode ENSNode related
Projects
ENSNode
Status: Backlog
Milestone
v2+
Development

No branches or pull requests
2 participants
@shrugs @lightwalker-eth