Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isCellNavigable is ignored when holding shift #278

Open
maejoh opened this issue Apr 15, 2021 · 0 comments
Open

isCellNavigable is ignored when holding shift #278

maejoh opened this issue Apr 15, 2021 · 0 comments

Comments

@maejoh
Copy link

maejoh commented Apr 15, 2021

I'm simulating merged cells with colspan and rowspan. I added cells with the 'display: none' style in places where the cell was really covered by an elongated cell, and made a function for isCellNavigable that considers such hidden cells as not navigable. This slightly improves keyboard navigation around the spreadsheet, though it isn't perfect. However, when selecting multiple cells by holding down the shift key, the hidden cells are being included.

image

For example, if I have cell B selected and press the right arrow key, cell G becomes selected (cell D and E are technically in the row above, so there are two filler cells in between B and G to make columns align for vertical navigation; they're set as non-navigable, so they're skipped when using keyboard movement).

But if I select cell B, and hold shift, I have to hit the right arrow key twice to select cell G. This wouldn't be a problem if that were because it was selecting cell D and E in between (which would be the best outcome), but since those don't appear to be selected, I can only assume the extra required keystrokes are due to the hidden cells being navigated to.

I believe this is a bug with keyboard navigation not taking isCellNavigable into account when the shift key is held for multi-cell selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant