Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound replaying #70

Open
cweng777 opened this issue May 28, 2020 · 1 comment · May be fixed by #72
Open

sound replaying #70

cweng777 opened this issue May 28, 2020 · 1 comment · May be fixed by #72

Comments

@cweng777
Copy link

cweng777 commented May 28, 2020

Hi, at the "SAVED RECORDINGS" screen, if the user's permission is not granted, the first time to pause during the replaying will fail.
Here is the bug report:
Environment
Android mobile phone/emulator
App version : 2.0.2
Device model : Galaxy J7, emulator
Android version : 6.0.1, 9
Steps to reproduce
Go to setting-> find the SoundRecorder app-> remove the storage permission ->
open the SoundRecorder app->select the "SAVED RECORDINGS" screen ->
select one sound file->click play button to replay as the dialog shows ->
The system will ask the permission, click "allow" ->
click the pause button
Expected Result
Replaying stops
Actual Result
Replaying continues
Visual Proof (video)
https://media.oregonstate.edu/media/t/0_tc3cie01

@cweng777
Copy link
Author

cweng777 commented May 28, 2020

I fixed it by changing one variable in PlaybackFragment.
There is one control variable "isPlaying" which should be true after the user gives the storage permission. Otherwise, the first time to pause will fail.
Here is the video of my change:
https://media.oregonstate.edu/media/t/0_vv4a70e8
Thank you

@cweng777 cweng777 linked a pull request May 28, 2020 that will close this issue
@naXa777 naXa777 linked a pull request Oct 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant