Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more upy #41

Merged
merged 27 commits into from
Jun 16, 2022
Merged

No more upy #41

merged 27 commits into from
Jun 16, 2022

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 14, 2022 •
edited
Loading

This revokes the experimental support for micropython. Going forward, it'd be better to rely on blinka's progress toward micropython support (adafruit/Adafruit_Blinka#480) which is currently hindered for the same reason I'm revoking it here - the utime lib.

It also fixes #40 by reverting all use of f-strings back to str.format().

Other various changes include:

  • Complete type hinting. I'm worried this might break compatibility with much older versions of CircuitPython, but v6+ is highly recommended for execution speeds (v7+ is better with mpy compression).
  • RF24 class uses allocated _in and _out buffers (instance attributes) for SPI transactions. This is based on some "pro-tips" about using micropython.
  • various doc updates.
  • improved network example to allow receiving while idling during emit()
  • improve setup.py for MacOS installs
  • allow saving/loading DHCP as a binary file. This should help people to migrate existing networks that use the C++ RF24Mesh library.

2bndy5 added 24 commits January 13, 2022 16:24
@2bndy5
no more f-strings; fix docs' spelling
e47f2c8
@2bndy5
remove upy wrappers
8846db6
@2bndy5
pre-allocate SPI buffers in rf24.py; fix spelling
fa3da5d
@2bndy5
add RF24NetHeader.__repr__(); improve docs
c1255c2
@2bndy5
update setup.py for macos installs
e311517
@2bndy5
oops platform.system is a callable
f437565
@2bndy5
only require spidev for Linux arm* devices
4cb4641
@2bndy5
update reqs.txt
b199944
@2bndy5
update network example
34331de
@2bndy5
Update topology.rst
e31a436
@2bndy5
add as_bin param to save/load_dhcp()
cf76dc8
@2bndy5
fix refs to logical address in topology doc
cdfaf3c
@2bndy5
Update conf.py
01786eb
@2bndy5
align with doc theme updates
2a52624
@2bndy5
update docs for theme changes
3be9978
@2bndy5
CI use python 3.9
9f9320a
@2bndy5
try python 3.8
c4e8299
@2bndy5
Revert "try python 3.8"
72f00f7 
This reverts commit c4e8299.
@2bndy5
minor changes in docs and CI
632afb5
@2bndy5
complete type hinting
918d692
@2bndy5
pleasing latest updates to pylint
767b685
@2bndy5
pleasing pylint
1a21119
@2bndy5
use typing-extensions pkg for Literal typing
4d5eadc
@2bndy5
ble example flush RX FIFO on exit slave()
43e9ae0
2bndy5
2bndy5 commented Jun 14, 2022
View reviewed changes
Copy link
Member Author

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found punctuation errors (yet again)

circuitpython_nrf24l01/fake_ble.py Outdated Show resolved Hide resolved
circuitpython_nrf24l01/network/mixins.py Outdated Show resolved Hide resolved
circuitpython_nrf24l01/rf24_mesh.py Outdated Show resolved Hide resolved
circuitpython_nrf24l01/rf24_mesh.py Outdated Show resolved Hide resolved
docs/network_docs/mesh_api.rst Outdated Show resolved Hide resolved
@2bndy5 2bndy5 merged commit 9ce1c68 into master Jun 16, 2022
@2bndy5 2bndy5 deleted the no-more-upy branch June 16, 2022 09:14
adafruit-adabot added a commit to adafruit/CircuitPython_Community_Bundle that referenced this pull request Jun 17, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@77089da)
82b9ba2 
Updating https://github.com/2bndy5/CircuitPython_nRF24L01 to 2.1.1 from 2.1.0:
  > No more upy (nRF24/CircuitPython_nRF24L01#41)
  > update docs build instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircuitPython throws a syntax error on line 428 of rf24.py
1 participant
@2bndy5