Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some inputs have wrong height on mobile browsers #150

Open
gabbsmo opened this issue Aug 12, 2024 · 9 comments
Open

Some inputs have wrong height on mobile browsers #150

gabbsmo opened this issue Aug 12, 2024 · 9 comments

Comments

@gabbsmo
Copy link

gabbsmo commented Aug 12, 2024

Describe the bug
<select> and <input type="date"> looks OK in desktop browser, but does not have the same height as <input type="text"> on some mobile browsers.

To Reproduce
Steps to reproduce the behavior:
<select class="hoo-input-text><!-- omitted --></select>
<input type="date" class="hoo-input-text">

Expected behavior
Same height as <input type="text" class="hoo-input-text">

Smartphone:

  • Device: Samsung Galaxy S1
  • OS: Android
  • Browser: Samsung Internet

Additional context
I realize that there is a hoo-input-date class as well, but found that it missed some functionality from hoo-input-text, or I was using it wrong. Either way, hoo-input-text did everything I wanted out of the box, except for this issue.

I know the <select> tag is not in the style guide so technically not a bug, but works just as well as the date field I mentioned before. I can open a separate feature request issue for it if you want.

My workaround:

select.hoo-input-text,
input[type="date"].hoo-input-text {
    height: 1.875rem;
}

Fixed height is OK, since these field types are not multi-line.

@StfBauer
Copy link
Contributor

StfBauer commented Nov 3, 2024

Are you sure the base font size is set to 1rem at 16px?

@gabbsmo
Copy link
Author

gabbsmo commented Nov 3, 2024

Font size for .hoo-input-text is 0.875rem. Font size on html/body is undefined in CSS in my case so it defers to my browser settings.

@StfBauer
Copy link
Contributor

StfBauer commented Nov 3, 2024

Yes but if you change the font of your OS that the browser shows smaller text, this changes the font size on root. There is now browser default other then the default setting is set to 16px. Can you share a screenshot?

@gabbsmo
Copy link
Author

gabbsmo commented Nov 4, 2024

Sure thing.

Screenshot_20241104_130228_Samsung Internet
Screenshot_20241104_130245_Samsung Internet

@StfBauer
Copy link
Contributor

StfBauer commented Nov 4, 2024

Yeah that makes sense, seems like the have a different implementation of the control.

@gabbsmo
Copy link
Author

gabbsmo commented Nov 5, 2024

Indeed. Luckily, setting the height of the control works in this case. Also, font is not matching, but at least it looks better when height is matching.

@StfBauer
Copy link
Contributor

StfBauer commented Nov 5, 2024

I need to find an Android emulator to check what is going on there.

@gabbsmo
Copy link
Author

gabbsmo commented Nov 8, 2024

I frequently use BrowserStack for device testing. They have a sponsorship program for open source projects. https://www.browserstack.com/open-source

@StfBauer
Copy link
Contributor

Thanks haven't tought about that ;) - Submitted it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants