-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some inputs have wrong height on mobile browsers #150
Comments
Are you sure the base font size is set to 1rem at 16px? |
Font size for |
Yes but if you change the font of your OS that the browser shows smaller text, this changes the font size on root. There is now browser default other then the default setting is set to 16px. Can you share a screenshot? |
Yeah that makes sense, seems like the have a different implementation of the control. |
Indeed. Luckily, setting the height of the control works in this case. Also, font is not matching, but at least it looks better when height is matching. |
I need to find an Android emulator to check what is going on there. |
I frequently use BrowserStack for device testing. They have a sponsorship program for open source projects. https://www.browserstack.com/open-source |
Thanks haven't tought about that ;) - Submitted it now. |
Describe the bug
<select>
and<input type="date">
looks OK in desktop browser, but does not have the same height as<input type="text">
on some mobile browsers.To Reproduce
Steps to reproduce the behavior:
<select class="hoo-input-text><!-- omitted --></select>
<input type="date" class="hoo-input-text">
Expected behavior
Same height as
<input type="text" class="hoo-input-text">
Smartphone:
Additional context
I realize that there is a
hoo-input-date
class as well, but found that it missed some functionality fromhoo-input-text
, or I was using it wrong. Either way,hoo-input-text
did everything I wanted out of the box, except for this issue.I know the
<select>
tag is not in the style guide so technically not a bug, but works just as well as the date field I mentioned before. I can open a separate feature request issue for it if you want.My workaround:
Fixed height is OK, since these field types are not multi-line.
The text was updated successfully, but these errors were encountered: