Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/imgdiff: possible false positives on differently sized images #13

Open
jba opened this issue Dec 6, 2024 · 0 comments
Open

pkg/imgdiff: possible false positives on differently sized images #13

jba opened this issue Dec 6, 2024 · 0 comments

Comments

@jba
Copy link

jba commented Dec 6, 2024

If image2 is larger than image1 but the overlap is identical, Diff will report that they are identical.
Either check that the sizes are equal at the top of Diff, or compute the bounds like this:

bounds := image1.Bounds().Union(image2.Bounds())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jba