New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/imgdiff: upper image bounds should be exclusive #12

Open

jba opened this issue Dec 6, 2024 · 0 comments

jba commented Dec 6, 2024

The max point of a bounding rectangle for an image.Image is exclusive.
So the current loops

			for y := i; y <= image1.Bounds().Max.Y; y += cpus {
				for x := 0; x <= image1.Bounds().Max.X; x++ {

actually go one past the end.
Replace both <= with <.
Luckily Image.At doesn't panic in this case, but the code is still technically wrong.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment