Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENOENT when dest in tmpdir (#60) #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nandenjin
Copy link

Fixes #60 .

  • Make normalizePath()returns absolute path
  • Fix lint errors (to run tests)

I'm not sure how this change affects in other environment or cases. Let me know if anyone notice about this.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #61 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   83.93%   83.87%   -0.06%     
==========================================
  Files          17       17              
  Lines         610      459     -151     
==========================================
- Hits          512      385     -127     
+ Misses         98       74      -24
Impacted Files Coverage Δ
lib/utils/normalize-path.js 77.77% <100%> (-2.23%) ⬇️
lib/utils/copy-file.js 65.78% <0%> (-5.37%) ⬇️
lib/utils/watcher.js 80% <0%> (-2.31%) ⬇️
lib/utils/apply-action.js 62.5% <0%> (-1.39%) ⬇️
lib/utils/normalize-options.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692b67b...84ece59. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws ENOENT when dest is in tmpdir
1 participant