44 FIX - Improve spec validation messages (go-openapi#42)

* Initial commit. Do not merge

* Good enough. UT perhaps borderline with default 10min timeout on my machine...

* Fixed FailNow() exception. Removed unused loop in code

* Externalized expected messages for UT in yaml. Trying to reproduce CI pb

* Skipped from CI: long running test MessageQualityContinueOnErrors_Issue44

* Skip another message validation UT...

* Skipped 2 more long running UT

* Bump and check if spec pkg still broken

* Bump to CI

* More UT. Arg in test to skip/pass long running tests

* Cleaned up un-necessary files in ./fixtures/go-swagger copied from go-swagger/go-swagger

* +UT for hasDuplicate() (never used in code). BTW this method should probably be removed. It looks like it is obsolete and superseded by values.go:UniqueItems()

* set mutex on regexp cache

* Fix mutex w/ panic testcase on mustCompileRegexp

Author: fredbi

debug.go

@@ -0,0 +1,18 @@
+package validate
+
+import (
+	"log"
+	"os"
+)
+
+var (
+	// Debug is true when the SWAGGER_DEBUG env var is not empty
+	Debug = os.Getenv("SWAGGER_DEBUG") != ""
+)
+
+func debugLog(msg string, args ...interface{}) {
+	// a private, trivial trace logger, based on go-openapi/spec/expander.go:debugLog()
+	if Debug {
+		log.Printf(msg, args...)
+	}
+}

fixtures/go-swagger/bugs/1010/swagger.yml

@@ -0,0 +1,16 @@
+swagger: "2.0"
+paths:
+  /widgets/:
+    get:
+      summary: Retrieve all widgets.
+      parameters:
+        - name: category_id
+          in: query
+          description: Return the widgets that are associated with this category.
+          required: true
+          type: array
+          collectionFormat: "multi"
+          items:
+            type: string
+            pattern: '^[0-9abcdefghjkmnpqrtuvwxyz]{29}$'
+definitions: {}