Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx omni completion #169

Open
plexigras opened this issue Apr 27, 2018 · 3 comments
Open

jsx omni completion #169

plexigras opened this issue Apr 27, 2018 · 3 comments

Comments

@plexigras
Copy link

i'm not sure how hard it is to write a custom omnicomp function but i think it would be nice to have.

https://github.com/vim/vim/blob/master/runtime/autoload/htmlcomplete.vim

https://github.com/vim/vim/blob/master/runtime/autoload/javascriptcomplete.vim

@chemzqm
Copy link

chemzqm commented May 13, 2018

The language server of typescript could do that, it requires parse syntax tree, but viml could hardly do that job.

@plexigras
Copy link
Author

but viml could hardly do that job.

why is that?

the html completion itself has css and javascript completion for <style> and <script> tags and this would just be the reverse so html completion inside of javascritp

https://github.com/vim/vim/blob/master/runtime/autoload/htmlcomplete.vim#L175-L192

@plexigras
Copy link
Author

but for now just adding setlocal omnifunc=htmlcomplete#CompleteTags to ~/.vim/ftplugin/jsx.vim is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants