Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please comment the code! #78

Open
10maurycy10 opened this issue Aug 11, 2022 · 6 comments
Open

Please comment the code! #78

10maurycy10 opened this issue Aug 11, 2022 · 6 comments

Comments

@10maurycy10
Copy link

Comments make reading and debugging the code much easier.

They are especially necessary if the code has one letter variable names!

@mxgmn
Copy link
Owner

mxgmn commented Aug 12, 2022

I agree. Will add a few comments when I have time. Right now I can say that in SimpleTiledModel.cs a is a 90 degrees rotation, and b is tile reflection.

@segrallx
Copy link

segrallx commented Dec 5, 2022

hello,what's the meaning of symmetry?
cardinality ?
func a b ?

need some comments. thanks..
or is any place we can talk about wfc . maybe anybody need some help or communicate.

@appgurueu
Copy link

hello,what's the meaning of symmetry?

Google it.

cardinality ?

Google it.

Comments are not the place for defining basic mathematical terms.

@segrallx
Copy link

segrallx commented Dec 5, 2022

thank you , i still consued about the meaning of X ,F, L ,T
could you tell me what symmetry they are representing?

@mxgmn
Copy link
Owner

mxgmn commented Dec 5, 2022

X, F, L, T are types of tile symmetries. X means a fully symmetric tile: you can rotate it 90, 180, 270 degrees or reflect it, and it would still look the same (like letter X). L can be reflected along the line y=x. F has no nontrivial symmetries.

@ldo
Copy link

ldo commented Jan 7, 2023

Cardinality: how many orientations (excluding reflection) of a tile with this symmetry can be distinguished.

Func<int, int> a, b: I call a the rotate_func — the function that transforms the index of a tile orientation to the one for the next 90° rotation anticlockwise — and b the reflect_func — the function that transforms the index of a tile orientation to the one for the reflected version.

Also worth pointing out that all the quantum mumbo-jumbo is a complete red herring. If you want a physical analogy, use the term “phase change”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants