Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy pass header metadata #14

Open
liule opened this issue Jun 6, 2017 · 4 comments
Open

proxy pass header metadata #14

liule opened this issue Jun 6, 2017 · 4 comments
Labels

Comments

@liule
Copy link

liule commented Jun 6, 2017

hi,
Metadata can't pass client to server by grpc-proxy, what can I do to pass metadata , thanks a lot

@mwitkow
Copy link
Owner

mwitkow commented Jun 14, 2017

Sorry, I don't understand.

Do toy mean: if a client request carries metadata, the grpc-proxy doesn't pass it to the backend?

That's weird because there's a test for that:
https://github.com/mwitkow/grpc-proxy/blob/master/proxy/handler_test.go#L118

simonhorlick added a commit to simonhorlick/grpc-proxy that referenced this issue Jun 29, 2017
This seems to have been caused by a change in grpc-go:
grpc/grpc-go@0c1d39d

This fixes mwitkow#14
@chensunny
Copy link

this case by gRPC new version which make metadata to Income-metadata and Outcome-metadata, so that the grpc-proxy doesn't pass it to the backend, i have fix in my brench.

by add this code.

  •   md, _ := metadata.FromContext(clientCtx)
    
  •   clientCtx = metadata.NewOutgoingContext(clientCtx, md)
    

@liule
Copy link
Author

liule commented Aug 2, 2017

@mwitkow @chensunny thanks。

@ghost
Copy link

ghost commented Jan 30, 2018

It seems this was fixed in last commit, but issue was not closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants