Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom width and height for Cards. #18

Open
ghost opened this issue Jun 18, 2016 · 3 comments
Open

Custom width and height for Cards. #18

ghost opened this issue Jun 18, 2016 · 3 comments
Assignees
@tushar-nallan
Labels
enhancement help wanted

Comments

@ghost
Copy link

ghost commented Jun 18, 2016

Currently the width and height are hard coded in the FrameLayout. This needs to be address if developers require to customize their layout. For e.g. changing the height of the card in card.xml or settings_card.xml does not have changes on the UI.
@ghost ghost changed the title Custom width and height for FrameLayout. Custom width and height for Cards. Jun 18, 2016
@tushar-nallan tushar-nallan self-assigned this Jul 19, 2016
@ghost
Copy link
Author

ghost commented Jul 19, 2016

You could probably make setters, allowing developers to set custom width and height as you have it for CardGap and CardGapBottom.

@mustafa01ali
Copy link
Contributor

Hey @omkaramberkar, that's a good suggestion! Would you mind raising a PR with the changes? We'll be happy to review and merge it :)

@ghost
Copy link
Author

ghost commented Jul 20, 2016

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tushar-nallan tushar-nallan

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mustafa01ali @tushar-nallan